Exclude static fields from the builder required ones #3933

sugmanue · 2023-04-21T00:40:06Z

Motivation and Context

Currently the ToBuilderIsCorrect validation does not exclude static fields in the builders class and errors out with these fields, e.g., for a class with

class Builder {
   private static final DEFAULT_EXCEPTION_TOKEN_COST = 10;
   private static final DEFAULT_TOKEN_BUCKET_SIZE = 500;
   ...
}

The validation will output something like:

toBuilder() does not update all of the builder's fields. Missing fields: [DEFAULT_EXCEPTION_TOKEN_COST, DEFAULT_TOKEN_BUCKET_SIZE]. This check does not currently consider transitive method calls. If this is a false positive, you can ignore this field by annotating the toBuilder method with @ToBuilderIgnoreField and specifying the fields to ignore.

Modifications

Exclude the fields that are marked as static.

Testing

Tested with the class that cause the error above.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

I have read the CONTRIBUTING document
Local run of mvn install succeeds
My code follows the code style of this project
My change requires a change to the Javadoc documentation
I have updated the Javadoc documentation accordingly
I have added tests to cover my changes
All new and existing tests passed
I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
My change is to implement 1.11 parity feature and I have updated LaunchChangelog