Skip to content

NettyUtils: added safe check for null pointers. Added regression tests. #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

martinKindall
Copy link
Contributor

@martinKindall martinKindall commented Apr 23, 2023

Motivation and Context

#3935

Modifications

Added null-pointer check and regression tests to increase coverage.

Testing

The included tests were tested running the unit tests of that module with ./mvnw package
Testing environment

JDK: java-1.8.0-amazon-corretto-devel
OS: Amazon Linux 2 Kernel 5.10, 64 bits.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@martinKindall martinKindall requested a review from a team as a code owner April 23, 2023 13:54
@debora-ito debora-ito added the needs-review This issue or PR needs review from the team. label Apr 27, 2023
@zoewangg
Copy link
Contributor

@martinKindall thank you for submitting the PR! Running tests now

@zoewangg zoewangg removed the needs-review This issue or PR needs review from the team. label Apr 27, 2023
@zoewangg zoewangg self-assigned this Apr 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

93.8% 93.8% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit be6a90c into aws:master Apr 28, 2023
@debora-ito
Copy link
Member

@all-contributors please add @martinKindall for code.

@allcontributors
Copy link
Contributor

@debora-ito

I've put up a pull request to add @martinKindall! 🎉

aws-sdk-java-automation added a commit that referenced this pull request May 14, 2025
…ae543d39a

Pull request: release <- staging/4ce69864-c039-423d-9508-6c6ae543d39a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants