Remove identity join in async client for endpoint discovery #3947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
gosar
commented
Apr 26, 2023
| .addCode(" .flatMap($T::credentialsIdentityProvider)", AwsRequestOverrideConfiguration.class) | ||
| .addCode(" .orElseGet(() -> clientConfiguration.option($T.CREDENTIALS_IDENTITY_PROVIDER))", | ||
| AwsClientOption.class) | ||
| // TODO: avoid join inside async | ||
| .addCode(" .resolveIdentity().join().accessKeyId();"); |
There was a problem hiding this comment.
This PR only changes the handling in AsyncClientClass.java. A join will remain in SyncClientClass.java, though it will change slightly for exception handling - that'll be in a separate PR.
gosar
commented
Apr 26, 2023
Comment on lines
-243
to
+245
| builder.add("\n\n$T<$T> executeFuture = clientHandler.execute(new $T<$T, $T>()\n", | ||
| CompletableFuture.class, executeFutureValueType, ClientExecutionParams.class, requestType, responseType) | ||
| builder.add("\n\n$T<$T> executeFuture = ", CompletableFuture.class, executeFutureValueType) | ||
| .add(opModel.getEndpointDiscovery() != null ? "endpointFuture.thenCompose(cachedEndpoint -> " : "") | ||
| .add("clientHandler.execute(new $T<$T, $T>()\n", ClientExecutionParams.class, requestType, responseType) |
There was a problem hiding this comment.
Only JsonProtocolSpec changed. No other ProtocolSpec has handling in its asyncExecutionHandler for discoveredEndpoint.
millems
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Identity resolution is async now. Inside async client we shouldn't
join(). This removes earlier use ofjoin()in endpoint discovery logic in async clients, addressing #3829 (comment).Modifications
Uses combination of thenApply and thenCompose to get from credentials->endpoint->execute.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License