Revert temporary module changes for new modules #3966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This makes the build work without disabling the maven-dependency-plugin and removes the Placeholder files. This could allow the
feature/master/sra-identity-auth
branch to potentially be merged tomaster
if we wanted to release the branch with just identity changes done. Not planning to merge to master just yet, but removing this blocker for whenever we are ready to merge.Modifications
Reverts most of the changes in #3764, except for identity-spi which has been coded in this branch. When I made the earlier PR, I was new to Maven modules and this codebase and thought I could get the Maven module changes done independently. But it is better to do them piecemeal. Going forward, will make the corresponding changes as and when new modules are added.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License