Skip to content

Revert temporary module changes for new modules #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

gosar
Copy link
Contributor

@gosar gosar commented May 2, 2023

Motivation and Context

This makes the build work without disabling the maven-dependency-plugin and removes the Placeholder files. This could allow the feature/master/sra-identity-auth branch to potentially be merged to master if we wanted to release the branch with just identity changes done. Not planning to merge to master just yet, but removing this blocker for whenever we are ready to merge.

Modifications

Reverts most of the changes in #3764, except for identity-spi which has been coded in this branch. When I made the earlier PR, I was new to Maven modules and this codebase and thought I could get the Maven module changes done independently. But it is better to do them piecemeal. Going forward, will make the corresponding changes as and when new modules are added.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

This makes the build work without disabling the
maven-dependency-plugin and removes the Placeholder files.
</dependency>
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>utils</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not related to a new SRA module, but was a copy paste error. utils is already a dependency listed above, so this was duplicate.

@gosar gosar marked this pull request as ready for review May 2, 2023 23:41
@gosar gosar requested a review from a team as a code owner May 2, 2023 23:41
@gosar gosar requested a review from cenedhryn May 2, 2023 23:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 50 Code Smells

58.8% 58.8% Coverage
2.3% 2.3% Duplication

@gosar gosar merged commit 86fb7df into feature/master/sra-identity-auth May 3, 2023
@gosar gosar deleted the modules-revert branch May 3, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants