Added Consumer<Builder> methods to varargs methods. #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorea
reviewed
Apr 18, 2018
| @Override | ||
| @SafeVarargs | ||
| public final Builder recursiveList(Consumer<Builder>... recursiveList) { | ||
| recursiveList(Arrays.asList(recursiveList).stream().map(c -> RecursiveStructType.builder().apply(c).build()) |
There was a problem hiding this comment.
Can you use Stream.of here? Possibly more efficient (not sure how it's implemented) but is a bit more concise too.
millems
force-pushed
the
millem/varargs-consumer-builders
branch
from
ac80d54 to
650581e
Compare
|
Consumer on varargs - mind blown |
shorea
approved these changes
Apr 19, 2018
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 2, 2019
…80238a2f Pull request: release <- staging/93953e98-41a8-484d-9d32-986980238a2f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.