Skip to content

Update v4 request signer to log AWS4 canonical request if DEBUG level… #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Apr 25, 2024

… is enabled

Motivation and Context

AWS4 canonical request is important for diagnosing SignatureMismatch errors. It's logged in AbstractAws4Signer prior to 2.20.x, but the new signer DefaultV4RequestSigner doesn't log it, which makes troubleshooting a lot harder.

LOG.debug(() -> "AWS4 Canonical Request: " + canonicalRequest);

Modifications

Update v4 request signer to log AWS4 canonical request at DEBUG level

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner April 25, 2024 23:09
Copy link
Contributor

@cenedhryn cenedhryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, it's really important for troubleshooting.

@zoewangg zoewangg enabled auto-merge (squash) April 26, 2024 20:13
Copy link

@zoewangg zoewangg merged commit e4fb225 into master Apr 26, 2024
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants