Adding guidance to MD5 calculation exception message #5186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
approved these changes
May 6, 2024
|
anirudh9391
pushed a commit
that referenced
this pull request
Jun 7, 2024
akidambisrinivasan
pushed a commit
to akidambisrinivasan/aws-sdk-java-v2
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If MD5 calculation fails because there is no available algorithm in the underlying JVM, this could be because the SDK is executing in a FIPS environment, where MD5 is no longer allowed due to compliance reasons.
In addition to disabling MD5 checks on SQS message responses if the flag
checksumValidationEnabledflag is set to false (PR #4729), this PR informs users with failing calculations that the flag exists by extending the exception message.