Skip to content

Fix the several typos detected by github.com/client9/misspell #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Aug 8, 2018

Description

This pull request fixes typos in this repository. Although I am not a native English speaker, misspell detected obvious mistakes for us. I've fixed them except for false positives.

Motivation and Context

$ find . -name *.java | xargs misspell
./http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/SdkEventLoopGroup.java:121:72: "succesful" is a misspelling of "successful"
./core/aws-core/src/main/java/software/amazon/awssdk/awscore/protocol/xml/StaxUnmarshallerContext.java:151:22: "psuedo" is a misspelling of "pseudo"
./core/aws-core/src/main/java/software/amazon/awssdk/awscore/protocol/xml/StaxUnmarshallerContext.java:168:22: "psuedo" is a misspelling of "pseudo"
./core/regions/src/main/java/software/amazon/awssdk/regions/internal/model/Service.java:115:9: "convienient" is a misspelling of "convenient"
./core/auth/src/main/java/software/amazon/awssdk/auth/credentials/ContainerCredentialsProvider.java:137:92: "withing" is a misspelling of "within"
./core/sdk-core/src/test/java/software/amazon/awssdk/core/util/XpathUtilsTest.java:205:33: "existant" is a misspelling of "existent"
./core/sdk-core/src/test/java/software/amazon/awssdk/core/util/XpathUtilsTest.java:206:31: "existant" is a misspelling of "existent"
./core/sdk-core/src/test/java/software/amazon/awssdk/core/util/XpathUtilsTest.java:207:34: "existant" is a misspelling of "existent"
./core/sdk-core/src/test/java/software/amazon/awssdk/core/util/XpathUtilsTest.java:208:31: "existant" is a misspelling of "existent"
./core/sdk-core/src/test/java/software/amazon/awssdk/core/util/XpathUtilsTest.java:209:32: "existant" is a misspelling of "existent"
./core/sdk-core/src/test/java/software/amazon/awssdk/core/util/XpathUtilsTest.java:210:33: "existant" is a misspelling of "existent"
./core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/protocol/json/SdkCborGenerator.java:31:38: "TIMESTAP" is a misspelling of "TIMESTAMP"
./core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/protocol/json/SdkCborGenerator.java:50:40: "TIMESTAP" is a misspelling of "TIMESTAMP"
./test/test-utils/src/main/java/software/amazon/awssdk/core/auth/policy/internal/JsonPolicyReader.java:40:32: "PRINICIPAL" is a misspelling of "PRINCIPAL"
./test/test-utils/src/main/java/software/amazon/awssdk/core/auth/policy/internal/JsonPolicyReader.java:250:43: "PRINICIPAL" is a misspelling of "PRINCIPAL"
./test/test-utils/src/main/java/software/amazon/awssdk/core/auth/policy/internal/JsonPolicyReader.java:255:37: "PRINICIPAL" is a misspelling of "PRINCIPAL"
./test/test-utils/src/main/java/software/amazon/awssdk/core/waiters/WaiterAcceptor.java:26:7: "Overriden" is a misspelling of "Overridden"
./test/test-utils/src/main/java/software/amazon/awssdk/core/waiters/WaiterAcceptor.java:30:16: "overriden" is a misspelling of "overridden"
./test/test-utils/src/main/java/software/amazon/awssdk/core/waiters/WaiterAcceptor.java:40:7: "Overriden" is a misspelling of "Overridden"
./test/test-utils/src/main/java/software/amazon/awssdk/core/waiters/WaiterAcceptor.java:44:16: "overriden" is a misspelling of "overridden"
./test/dynamodbdocument-v1/src/it/java/software/amazon/awssdk/services/dynamodb/document/UpdateItemIntegrationTest.java:269:70: "conditon" is a misspelling of "condition"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/DynamoDbTyped.java:81:25: "omited" is a misspelling of "omitted"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/DynamoDbTyped.java:82:51: "overriden" is a misspelling of "overridden"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/DynamoDbTyped.java:87:60: "omited" is a misspelling of "omitted"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/DynamoDbMarshaller.java:31:22: "recomended" is a misspelling of "recommended"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/DynamoDbTypeConverterFactory.java:112:54: "overriden" is a misspelling of "overridden"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/DynamoDbMarshalling.java:45:22: "recomended" is a misspelling of "recommended"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/StandardModelFactoriesTest.java:1619:18: "assersions" is a misspelling of "assertions"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/DynamoDbScalarAttribute.java:40:18: "attirbute" is a misspelling of "attribute"
./test/dynamodbmapper-v1/src/test/java/software/amazon/awssdk/services/dynamodb/datamodeling/DynamoDbMappingException.java:19:34: "occuring" is a misspelling of "occurring"
./test/dynamodbmapper-v1/src/it/java/software/amazon/awssdk/services/dynamodb/datamodeling/BatchLoadIntegrationTest.java:165:52: "existant" is a misspelling of "existent"
./test/dynamodbmapper-v1/src/it/java/software/amazon/awssdk/services/dynamodb/datamodeling/BatchLoadIntegrationTest.java:206:31: "expection" is a misspelling of "exception"
./codegen/src/test/java/software/amazon/awssdk/codegen/naming/DefaultNamingStrategyTest.java:49:34: "strat" is a misspelling of "start"
./codegen/src/main/java/software/amazon/awssdk/codegen/docs/DocumentationBuilder.java:211:50: "configuraton" is a misspelling of "configuration"
./services/dynamodb/src/it/java/software/amazon/awssdk/services/dynamodb/DynamoServiceIntegrationTest.java:151:81: "existant" is a misspelling of "existent"
./services/autoscaling/src/it/java/software/amazon/awssdk/services/autoscaling/AutoScalingIntegrationTest.java:505:36: "notificaiton" is a misspelling of "notification"
./services/stepfunctions/src/main/java/software/amazon/awssdk/services/stepfunctions/builder/internal/validation/Problem.java:35:47: "occured" is a misspelling of "occurred"

Testing

This pull request should never bring any changes to the behavior of the library.

Screenshots (if appropriate)

None.

Types of changes

Fixing the wordings mainly in comments.

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing the typos!

@@ -1624,7 +1624,7 @@
"members":{
"graphqlApi":{
"shape":"GraphqlApi",
"documentation":"<p>The udpated <code>GraphqlApi</code> object.</p>"
"documentation":"<p>The updated <code>GraphqlApi</code> object.</p>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this file is auto generated by the service model provided by the service team and the change will likely be reverted unless the service team fix it on the service model.

@zoewangg zoewangg merged commit d72067e into aws:master Aug 8, 2018
@seratch seratch deleted the fix-typos branch August 8, 2018 22:10
aws-sdk-java-automation added a commit that referenced this pull request Oct 29, 2019
…45342d12

Pull request: release <- staging/fb2b44a7-9025-4113-8644-0b2745342d12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants