Skip to content

Filter blanks in getJavaClassName #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 2, 2018

Description

This ports the same fix added to DefaultNamingStrategy from V1.

Related to #693.

Motivation and Context

Update service models.

Testing

mvn clean install, also ported over tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • I confirm that this pull request can be released under the Apache 2 license

This ports the same fix added to DefaultNamingStrategy from V1.

Related to aws#693.
@dagnir dagnir requested a review from spfink October 2, 2018 00:04
@dagnir dagnir merged commit 0fde051 into aws:master Oct 2, 2018
aws-sdk-java-automation added a commit that referenced this pull request Feb 25, 2020
…4e8a760a

Pull request: release <- staging/2a082c6e-6a3e-46f7-a875-647e4e8a760a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants