Enable idle connection reaper for Apache client #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorea
reviewed
Oct 11, 2018
| } | ||
| public boolean registerConnectionManager(HttpClientConnectionManager manager, long maxIdleTime) { | ||
| boolean notPreviouslyRegistered = connectionManagers.put(manager, maxIdleTime) == null; | ||
| if (notPreviouslyRegistered) { |
There was a problem hiding this comment.
do we need the check of not previously registered since we are checking if the exec is null?
There was a problem hiding this comment.
Nope, don't think it's necessary.
| shutdown(); | ||
| public boolean deregisterConnectionManager(HttpClientConnectionManager manager) { | ||
| boolean wasRemoved = connectionManagers.remove(manager) != null; | ||
| if (wasRemoved) { |
There was a problem hiding this comment.
Don't follow this. Shouldn't we only shutdown if all connection managers are de-registered?
There was a problem hiding this comment.
Woops! Yeah should be an empty check
| @Override | ||
| public void run() { | ||
| while (true) { | ||
| if (stopping) { |
There was a problem hiding this comment.
Should we just put this in the while? while(!stopping)
shorea
approved these changes
Oct 11, 2018
dagnir
force-pushed
the
idle-connection-reaper
branch
from
6948203 to
88db521
Compare
aws-sdk-java-automation
added a commit
that referenced
this pull request
Mar 11, 2020
…ef632f8f Pull request: release <- staging/2b200b34-8d28-42cb-b359-a073ef632f8f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Testing
Added new tests.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense