Skip to content

Add Automatic-Module-Name manifest entry #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Oct 24, 2018

Description

  • Add Automatic-Module-Name manifest entry
  • Fix additional Generated annotation imports
  • Add javax.annotation.Generated to illegal import checkstyle rule
  • Rename protocol directories to match with their artifactId. eg: aws-query -> aws-query-protocol

#775

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from spfink October 24, 2018 17:45
@zoewangg zoewangg merged commit fa248a8 into master Oct 24, 2018
@zoewangg zoewangg deleted the zoewang-addAutomaticModuleName branch October 24, 2018 19:18
aws-sdk-java-automation added a commit that referenced this pull request Mar 31, 2020
…4a3351e4

Pull request: release <- staging/daa28b60-d856-44be-9c3f-fe934a3351e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants