Move protocols module under core module #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the name of the modules reflect the structure? I.E AWS Java SDK :: AWS Cbor Protocol -> AWS Java SDK :: Core :: Protocols :: AWS Cbor Protocol |
|
Good point! Will update |
shorea
reviewed
Oct 27, 2018
| @@ -10,6 +10,10 @@ | |||
| <modelVersion>4.0.0</modelVersion> | |||
|
|
|||
| <artifactId>aws-xml-protocol</artifactId> | |||
| <name>AWS Java SDK :: Core :: Protocols :: AWS Xml Core</name> | |||
There was a problem hiding this comment.
Oops, guess my brain is not functioning on Friday afternoon
shorea
approved these changes
Oct 29, 2018
zoewangg
force-pushed
the
zoewang-moveProtocolsModule
branch
from
43b104a to
1fb463a
Compare
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 7, 2020
…741bd62f Pull request: release <- staging/d459b8ff-0614-4a83-b793-cc61741bd62f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move
protocolsmodule undercoremodule so that it's consistent with other core modules.