Skip to content

updated plugins for Reproducible Builds (excl osgi) #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

hboutemy
Copy link

aws-java-sdk-osgi is the only remaining non-reproducible module, waiting
for Felix maven-bundle-plugin improvement

see https://maven.apache.org/guides/mini/guide-reproducible-builds.html for more information on how to configure a Maven build to get Reproducible Build

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aws-java-sdk-osgi is the only remaining non-reproducible module, waiting
for Felix maven-bundle-plugin improvement
@hboutemy
Copy link
Author

with second commit, fixing the OSGI reproducibility issue, aws-sdk-java becomes fully reproducible
@debora-ito @millems

@hboutemy
Copy link
Author

@debora-ito @millems it would be nice to add aws-sdk-java to https://github.com/jvm-repo-rebuild/reproducible-central

@millems
Copy link
Contributor

millems commented Apr 17, 2020

What are the relative merits of enabling reproducible builds for v1? We're generally hesitant to take PRs for v1, because it's a lot of effort to import into our internal build system, particularly when it affects our pom.xml files that are mostly generated.

We'd rather spend the time on v2: https://github.com/aws/aws-sdk-java-v2/

@hboutemy
Copy link
Author

Reproducible Builds merits are for any OSS used as binary https://reproducible-builds.org/

I did a PR for v2 some time ago aws/aws-sdk-java-v2#1759

Given we all have much to do, I can understand some form of prioritization

@github-actions
Copy link

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to provide a comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will close in 2 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will close in 2 days unless further comments are made. labels Apr 20, 2023
@github-actions github-actions bot closed this Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants