fix(service-error-classification): update status code logic

srchase · srchase · commit 071e6b12aa49 · 2022-12-09T10:02:33.000-07:00
diff --git a/packages/service-error-classification/src/index.ts b/packages/service-error-classification/src/index.ts
@@ -31,7 +31,7 @@ export const isTransientError = (error: SdkError) =>
 export const isServerError = (error: SdkError) => {
   if (error.$metadata?.httpStatusCode !== undefined) {
     const statusCode = error.$metadata.httpStatusCode;
-    if (statusCode > 499 && statusCode <= 599 && !isTransientError(error)) {
+    if (500 <= statusCode && statusCode <= 599 && !isTransientError(error)) {
       return true;
     }
     return false;

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export const isTransientError = (error: SdkError) =>`
`31`	`31`	`export const isServerError = (error: SdkError) => {`
`32`	`32`	`if (error.$metadata?.httpStatusCode !== undefined) {`
`33`	`33`	`const statusCode = error.$metadata.httpStatusCode;`
`34`		`- if (statusCode > 499 && statusCode <= 599 && !isTransientError(error)) {`
	`34`	`+ if (500 <= statusCode && statusCode <= 599 && !isTransientError(error)) {`
`35`	`35`	`return true;`
`36`	`36`	`}`
`37`	`37`	`return false;`