chore: address PR feedbacks

Author: AllanZhengYP

clients/client-transcribe-streaming/.npmignore

@@ -3,3 +3,4 @@
 /test/
 tsconfig.test.json
 *.tsbuildinfo
+jest.config.js

clients/client-transcribe-streaming/package.json

@@ -6,15 +6,18 @@
     "clean": "npm run remove-definitions && npm run remove-dist && npm run remove-js && npm run remove-maps",
     "build-documentation": "npm run clean && typedoc ./",
     "prepublishOnly": "yarn build",
-    "pretest": "tsc",
+    "pretest": "yarn build",
     "remove-definitions": "rimraf ./types",
     "remove-dist": "rimraf ./dist",
     "remove-documentation": "rimraf ./docs",
     "remove-js": "rimraf *.js && rimraf ./commands/*.js && rimraf ./models/*.js && rimraf ./protocols/*.js",
     "remove-maps": "rimraf *.js.map && rimraf ./commands/*.js.map && rimraf ./models/*.js.map && rimraf ./protocols/*.js.map",
-    "test": "yarn build && jest --coverage --passWithNoTests",
+    "test": "jest --coverage --passWithNoTests",
+    "test:integration": "jest --config jest.integ.config.js",
+    "build:cjs": "tsc",
     "build:es": "tsc -p tsconfig.es.json",
-    "build": "yarn pretest && yarn build:es"
+    "build": "yarn build:cjs && yarn build:es",
+    "postbuild": "cp test/speech.wav dist/cjs/test"
   },
   "main": "./dist/cjs/index.js",
   "types": "./types/index.d.ts",

clients/client-transcribe-streaming/test/index.integ.spec.ts

@@ -1,8 +1,7 @@
 import { TranscribeStreaming } from "../index";
 import { createReadStream } from "fs";
 import { join } from "path";
-const moduleRoot = join(__dirname, "..", "..", "..");
-const audio = createReadStream(join(moduleRoot, "test", "speech.wav"));
+const audio = createReadStream(join(__dirname, "speech.wav"));
 
 describe("TranscribeStream client", () => {
   const client = new TranscribeStreaming({});
@@ -11,19 +10,22 @@ describe("TranscribeStream client", () => {
   });
 
   it("should stream the transcript", async () => {
+    const LanguageCode = "en-US";
+    const MediaEncoding = "pcm";
+    const MediaSampleRateHertz = 44100;
     const result = await client.startStreamTranscription({
-      LanguageCode: "en-US",
-      MediaEncoding: "pcm",
-      MediaSampleRateHertz: 44100,
+      LanguageCode,
+      MediaEncoding,
+      MediaSampleRateHertz,
       AudioStream: (async function* () {
         for await (const chunk of audio) {
           yield { AudioEvent: { AudioChunk: chunk } };
         }
       })()
     });
-    expect(result.LanguageCode).toBe("en-US");
-    expect(result.MediaEncoding).toBe("pcm");
-    expect(result.MediaSampleRateHertz).toBe(44100);
+    expect(result.LanguageCode).toBe(LanguageCode);
+    expect(result.MediaEncoding).toBe(MediaEncoding);
+    expect(result.MediaSampleRateHertz).toBe(MediaSampleRateHertz);
     expect(result.TranscriptResultStream).toBeDefined();
     const transcripts = [];
     for await (const event of result.TranscriptResultStream!) {

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsRestXml.java

@@ -207,7 +207,7 @@ protected void serializeInputPayload(
             writer.write("contents = $L;",
                     getInputValue(context, Location.PAYLOAD, "input." + memberName, member, target));
 
-            // Structure and Union payloads that's not events stream will serialize as XML documents via XmlNode.
+            // XmlNode will serialize non-eventstream Structure and Union payloads as XML documents.
             if ((target instanceof StructureShape || target instanceof UnionShape)
                     && !member.hasTrait(EventStreamTrait.class)) {
                 // Start with the XML declaration.

package.json

@@ -17,7 +17,8 @@
     "pretest:all": "yarn build:all",
     "test:all": "jest --coverage --passWithNoTests && lerna run test --scope @aws-sdk/fetch-http-handler --scope @aws-sdk/hash-blob-browser",
     "test:functional": "jest --config tests/functional/jest.config.js --passWithNoTests",
-    "test:integration": "cucumber-js --fail-fast && jest --config jest.config.integ.js --passWithNoTests",
+    "test:integration-legacy": "cucumber-js --fail-fast",
+    "test:integration": "jest --config jest.config.integ.js --passWithNoTests",
     "test:protocols": "yarn build:protocols && lerna run test --scope '@aws-sdk/aws-*'"
   },
   "repository": {

packages/eventstream-handler-node/src/EventStreamPayloadHandler.spec.ts

@@ -20,9 +20,11 @@ describe("EventStreamPayloadHandler", () => {
   const mockUtf8Decoder: Decoder = jest.fn();
   const mockUtf8encoder: Encoder = jest.fn();
   const mockNextHandler: FinalizeHandler<any, any> = jest.fn();
+
   beforeEach(() => {
     jest.clearAllMocks();
   });
+
   it("should throw if request payload is not a stream", () => {
     const handler = new EventStreamPayloadHandler({
       eventSigner: () => Promise.resolve(mockSigner),
@@ -36,6 +38,7 @@ describe("EventStreamPayloadHandler", () => {
       })
     ).rejects.toThrow("Eventstream payload must be a Readable stream.");
   });
+
   it("should close the request payload if downstream middleware throws", async () => {
     (mockNextHandler as any).mockImplementationOnce(() =>
       Promise.reject(new Error())
@@ -62,6 +65,7 @@ describe("EventStreamPayloadHandler", () => {
       mockRequest.body.write("");
     }).toThrowError("write after end");
   });
+
   it("should call event signer with request signature from signing middleware", async () => {
     const authorization =
       "AWS4-HMAC-SHA256 Credential=AKID/20200510/us-west-2/foo/aws4_request, SignedHeaders=host, Signature=1234567890";
@@ -83,6 +87,7 @@ describe("EventStreamPayloadHandler", () => {
       "1234567890"
     );
   });
+
   it("should start piping to request payload through event signer if downstream middleware returns", async () => {
     const authorization =
       "AWS4-HMAC-SHA256 Credential=AKID/20200510/us-west-2/foo/aws4_request, SignedHeaders=host, Signature=1234567890";

packages/eventstream-serde-universal/src/getChunkedStream.ts

@@ -5,7 +5,7 @@ export function getChunkedStream(
   let currentMessagePendingLength = 0;
   let currentMessage: Uint8Array | null = null;
   let messageLengthBuffer: Uint8Array | null = null;
-  const allocateMessage = function (size: number) {
+  const allocateMessage = (size: number) => {
     if (typeof size !== "number") {
       throw new Error(
         "Attempted to allocate an event message where size was not a number: " +
@@ -21,17 +21,15 @@ export function getChunkedStream(
 
   const iterator = async function* () {
     const sourceIterator = source[Symbol.asyncIterator]();
-    let complete = false;
-    while (!complete) {
+    while (true) {
       const { value, done } = await sourceIterator.next();
-      complete = done || false;
       if (done) {
-        if (currentMessageTotalLength) {
-          if (currentMessageTotalLength === currentMessagePendingLength) {
-            yield currentMessage as Uint8Array;
-          } else {
-            throw new Error("Truncated event message received.");
-          }
+        if (!currentMessageTotalLength) {
+          return;
+        } else if (currentMessageTotalLength === currentMessagePendingLength) {
+          yield currentMessage as Uint8Array;
+        } else {
+          throw new Error("Truncated event message received.");
         }
         return;
       }

packages/middleware-eventstream/src/index.ts

@@ -1,4 +1,4 @@
 export * from "./configuration";
 export * from "./handling-middleware";
 export * from "./headers-middleware";
-export * from "./pluggin";
+export * from "./plugin";