chore: change var to let/const

Author: trivikr

features/acm/step_definitions/acm.js

@@ -1,4 +1,4 @@
-var { ACM } = require("../../../clients/client-acm");
+const { ACM } = require("../../../clients/client-acm");
 const { Before } = require("cucumber");
 
 Before({ tags: "@acm" }, function(scenario, callback) {

features/apigateway/step_definitions/apigateway.js

@@ -1,4 +1,4 @@
-var { APIGateway } = require("../../../clients/client-api-gateway");
+const { APIGateway } = require("../../../clients/client-api-gateway");
 const { Before } = require("cucumber");
 
 Before({ tags: "@apigateway" }, function(scenario, callback) {

features/autoscaling/step_definitions/autoscaling.js

@@ -1,4 +1,4 @@
-var { AutoScaling } = require("../../../clients/client-auto-scaling");
+const { AutoScaling } = require("../../../clients/client-auto-scaling");
 const { Before, Given, Then } = require("cucumber");
 
 Before({ tags: "@autoscaling" }, function(scenario, callback) {
@@ -10,7 +10,7 @@ Given(/^I create a launch configuration with name "([^"]*)"$/, function(
   name,
   callback
 ) {
-  var params = {
+  const params = {
     ImageId: "ami-1624987f",
     InstanceType: "m1.small",
     LaunchConfigurationName: name
@@ -33,6 +33,6 @@ Then(/^the list should contain the launch configuration "([^"]*)"$/, function(
 });
 
 Then(/^I delete the launch configuration "([^"]*)"$/, function(name, callback) {
-  var params = { LaunchConfigurationName: name };
+  const params = { LaunchConfigurationName: name };
   this.request(null, "deleteLaunchConfiguration", params, callback);
 });

features/cloudformation/step_definitions/cloudformation.js

@@ -1,4 +1,4 @@
-var { CloudFormation } = require("../../../clients/client-cloudformation");
+const { CloudFormation } = require("../../../clients/client-cloudformation");
 const { Before, Given } = require("cucumber");
 
 Before({ tags: "@cloudformation" }, function(scenario, callback) {
@@ -12,7 +12,7 @@ Given(/^I create a CloudFormation stack with name prefix "([^"]*)"$/, function(
 ) {
   this.stackName = this.uniqueName(prefix);
   this.templateBody = '{"Resources":{"member":{"Type":"AWS::SQS::Queue"}}}';
-  var params = {
+  const params = {
     TemplateBody: this.templateBody,
     StackName: this.stackName
   };

features/cloudfront/step_definitions/cloudfront.js

@@ -1,7 +1,7 @@
-var { CloudFront } = require("../../../clients/client-cloudfront");
+const { CloudFront } = require("../../../clients/client-cloudfront");
 const { Before, Given, Then, When } = require("cucumber");
 
-var createParams = {
+const createParams = {
   CallerReference: "",
   Aliases: {
     Quantity: 0

features/cloudsearch/step_definitions/cloudsearch.js

@@ -1,4 +1,4 @@
-var { CloudSearch } = require("../../../clients/client-cloudsearch");
+const { CloudSearch } = require("../../../clients/client-cloudsearch");
 const { Before, Given } = require("cucumber");
 
 Before({ tags: "@cloudsearch" }, function(scenario, callback) {

features/cloudtrail/step_definitions/cloudtrail.js

@@ -1,4 +1,4 @@
-var { CloudTrail } = require("../../../clients/client-cloudtrail");
+const { CloudTrail } = require("../../../clients/client-cloudtrail");
 const { Before, Given } = require("cucumber");
 
 Before({ tags: "@cloudtrail" }, function(scenario, callback) {

features/cloudwatch/step_definitions/cloudwatch.js

@@ -1,4 +1,4 @@
-var { CloudWatch } = require("../../../clients/client-cloudwatch");
+const { CloudWatch } = require("../../../clients/client-cloudwatch");
 const { Before, Given, Then } = require("cucumber");
 
 Before({ tags: "@cloudwatch" }, function(scenario, callback) {
@@ -11,7 +11,7 @@ Given(/^I create a CloudWatch alarm with (prefix|name) "([^"]*)"$/, function(
   name,
   callback
 ) {
-  var timestamp = new Date().getTime();
+  const timestamp = new Date().getTime();
   this.cloudWatchAlarm = {
     AlarmName: name,
     MetricName: "aws-sdk-js-metric-" + timestamp,
@@ -37,15 +37,15 @@ Given(/^I create a CloudWatch alarm with (prefix|name) "([^"]*)"$/, function(
 });
 
 Given(/^I list the CloudWatch alarms$/, function(callback) {
-  var params = {
+  const params = {
     MetricName: this.cloudWatchAlarm.MetricName,
     Namespace: this.cloudWatchAlarm.Namespace
   };
   this.request(null, "describeAlarmsForMetric", params, callback);
 });
 
 Then(/^the list should contain the CloudWatch alarm$/, function(callback) {
-  var name = this.cloudWatchAlarm.AlarmName;
+  const name = this.cloudWatchAlarm.AlarmName;
   this.assert.contains(this.data.MetricAlarms, function(alarm) {
     return alarm.AlarmName === name;
   });

features/cloudwatchevents/step_definitions/cloudwatchevents.js

@@ -1,4 +1,6 @@
-var { CloudWatchEvents } = require("../../../clients/client-cloudwatch-events");
+const {
+  CloudWatchEvents
+} = require("../../../clients/client-cloudwatch-events");
 const { Before } = require("cucumber");
 
 Before({ tags: "@cloudwatchevents" }, function(scenario, callback) {

features/cloudwatchlogs/step_definitions/cloudwatchlogs.js

@@ -1,4 +1,4 @@
-var { CloudWatchLogs } = require("../../../clients/client-cloudwatch-logs");
+const { CloudWatchLogs } = require("../../../clients/client-cloudwatch-logs");
 const { Before, Given, Then } = require("cucumber");
 
 Before({ tags: "@cloudwatchlogs" }, function(scenario, callback) {
@@ -10,7 +10,7 @@ Given(/^I create a CloudWatch logGroup with prefix "([^"]*)"$/, function(
   prefix,
   callback
 ) {
-  var expectErr = prefix === "" ? false : undefined;
+  const expectErr = prefix === "" ? false : undefined;
   this.logGroupName = this.uniqueName(prefix);
   this.request(
     null,
@@ -26,7 +26,7 @@ Given(/^I list the CloudWatch logGroups$/, function(callback) {
 });
 
 Then(/^the list should contain the CloudWatch logGroup$/, function(callback) {
-  var name = this.logGroupName;
+  const name = this.logGroupName;
   this.assert.contains(this.data.logGroups, function(alarm) {
     return alarm.logGroupName === name;
   });

features/codecommit/step_definitions/codecommit.js

@@ -1,4 +1,4 @@
-var { CodeCommit } = require("../../../clients/client-codecommit");
+const { CodeCommit } = require("../../../clients/client-codecommit");
 const { Before } = require("cucumber");
 
 Before({ tags: "@codecommit" }, function(scenario, callback) {

features/codedeploy/step_definitions/codedeploy.js

@@ -1,4 +1,4 @@
-var { CodeDeploy } = require("../../../clients/client-codedeploy");
+const { CodeDeploy } = require("../../../clients/client-codedeploy");
 const { Before } = require("cucumber");
 
 Before({ tags: "@codedeploy" }, function(scenario, callback) {

features/codepipeline/step_definitions/codepipeline.js

@@ -1,4 +1,4 @@
-var { CodePipeline } = require("../../../clients/client-codepipeline");
+const { CodePipeline } = require("../../../clients/client-codepipeline");
 const { Before } = require("cucumber");
 
 Before({ tags: "@codepipeline" }, function(scenario, callback) {

features/cognitoidentity/step_definitions/cognitoidentity.js

@@ -1,4 +1,4 @@
-var { CognitoIdentity } = require("../../../clients/client-cognito-identity");
+const { CognitoIdentity } = require("../../../clients/client-cognito-identity");
 const { Before, Given, Then } = require("cucumber");
 
 Before({ tags: "@cognitoidentity" }, function(scenario, callback) {
@@ -10,8 +10,8 @@ Given(/^I create a Cognito identity pool with prefix "([^"]*)"$/, function(
   prefix,
   callback
 ) {
-  var expectError = prefix === "" ? false : undefined;
-  var params = {
+  const expectError = prefix === "" ? false : undefined;
+  const params = {
     IdentityPoolName: this.uniqueName(prefix, ""),
     AllowUnauthenticatedIdentities: true
   };

features/cognitosync/step_definitions/cognitosync.js

@@ -1,4 +1,4 @@
-var { CognitoSync } = require("../../../clients/client-cognito-sync");
+const { CognitoSync } = require("../../../clients/client-cognito-sync");
 const { Before, Given } = require("cucumber");
 
 Before({ tags: "@cognitosync" }, function(scenario, callback) {
@@ -13,7 +13,7 @@ Given(/^I list Cognito identity pool usage$/, function(callback) {
 Given(
   /^I list Cognito data sets with identity pool id "([^"]*)" and identity id "([^"]*)"$/,
   function(idpid, idid, callback) {
-    var params = { IdentityPoolId: idpid, IdentityId: idid };
+    const params = { IdentityPoolId: idpid, IdentityId: idid };
     this.request(null, "listDatasets", params, callback, false);
   }
 );

features/configservice/step_definitions/configservice.js

@@ -1,4 +1,4 @@
-var { ConfigService } = require("../../../clients/client-config-service");
+const { ConfigService } = require("../../../clients/client-config-service");
 const { Before } = require("cucumber");
 
 Before({ tags: "@configservice" }, function(scenario, callback) {

features/datapipeline/step_definitions/datapipeline.js

@@ -1,4 +1,4 @@
-var { DataPipeline } = require("../../../clients/client-data-pipeline");
+const { DataPipeline } = require("../../../clients/client-data-pipeline");
 const { Before, Given } = require("cucumber");
 
 Before({ tags: "@datapipeline" }, function(scenario, callback) {
@@ -10,7 +10,7 @@ Given(/^I create a Data Pipeline with name prefix "([^"]*)"$/, function(
   prefix,
   callback
 ) {
-  var params = {
+  const params = {
     name: this.uniqueName(prefix),
     uniqueId: this.uniqueName("aws-js-sdk")
   };

features/devicefarm/step_definitions/devicefarm.js

@@ -1,4 +1,4 @@
-var { DeviceFarm } = require("../../../clients/client-device-farm");
+const { DeviceFarm } = require("../../../clients/client-device-farm");
 const { Before } = require("cucumber");
 
 Before({ tags: "@devicefarm" }, function(scenario, callback) {

features/directconnect/step_definitions/directconnect.js

@@ -1,4 +1,4 @@
-var { DirectConnect } = require("../../../clients/client-direct-connect");
+const { DirectConnect } = require("../../../clients/client-direct-connect");
 const { Before, Given } = require("cucumber");
 
 Before({ tags: "@directconnect" }, function(scenario, callback) {
@@ -9,7 +9,7 @@ Before({ tags: "@directconnect" }, function(scenario, callback) {
 Given(
   /^I create a Direct Connect connection with an invalid location$/,
   function(callback) {
-    var params = {
+    const params = {
       bandwidth: "1Gbps",
       location: "INVALID_LOCATION",
       connectionName: this.uniqueName("aws-sdk-js")

features/directoryservice/step_definitions/directoryservice.js

@@ -1,4 +1,6 @@
-var { DirectoryService } = require("../../../clients/client-directory-service");
+const {
+  DirectoryService
+} = require("../../../clients/client-directory-service");
 const { Before } = require("cucumber");
 
 Before({ tags: "@directoryservice" }, function(scenario, callback) {

features/dms/step_definitions/dms.js

@@ -1,4 +1,4 @@
-var {
+const {
   DatabaseMigrationService
 } = require("../../../clients/client-database-migration-service");
 const { Before } = require("cucumber");

features/dynamodb/step_definitions/dynamodb.js

@@ -1,5 +1,5 @@
-var jmespath = require("jmespath");
-var { DynamoDB } = require("../../../clients/client-dynamodb");
+const jmespath = require("jmespath");
+const { DynamoDB } = require("../../../clients/client-dynamodb");
 
 /**
  * Waits for the tableExists state by periodically calling the underlying
@@ -70,7 +70,7 @@ Before({ tags: "@dynamodb" }, function(scenario, next) {
 });
 
 function createTable(world, callback) {
-  var params = {
+  const params = {
     TableName: world.tableName,
     AttributeDefinitions: [{ AttributeName: "id", AttributeType: "S" }],
     KeySchema: [{ AttributeName: "id", KeyType: "HASH" }],
@@ -90,9 +90,9 @@ function createTable(world, callback) {
 }
 
 Given(/^I have a table$/, function(callback) {
-  var world = this;
+  const world = this;
   this.service.listTables({}, function(err, data) {
-    for (var i = 0; i < data.TableNames.length; i++) {
+    for (const i = 0; i < data.TableNames.length; i++) {
       if (data.TableNames[i] == world.tableName) {
         callback();
         return;
@@ -103,10 +103,10 @@ Given(/^I have a table$/, function(callback) {
 });
 
 When(/^I create a table$/, function(callback) {
-  var world = this;
+  const world = this;
   this.tableName = this.uniqueName("aws-sdk-js-integration");
   this.service.listTables({}, function(err, data) {
-    for (var i = 0; i < data.TableNames.length; i++) {
+    for (const i = 0; i < data.TableNames.length; i++) {
       if (data.TableNames[i] == world.tableName) {
         callback();
         return;
@@ -117,12 +117,12 @@ When(/^I create a table$/, function(callback) {
 });
 
 When(/^I put the item:$/, function(string, next) {
-  var params = { TableName: this.tableName, Item: JSON.parse(string) };
+  const params = { TableName: this.tableName, Item: JSON.parse(string) };
   this.request(null, "putItem", params, next);
 });
 
 When(/^I put a recursive item$/, function(next) {
-  var params = {
+  const params = {
     TableName: this.tableName,
     Item: {
       id: { S: "fooRecursive" },
@@ -147,7 +147,7 @@ When(/^I put a recursive item$/, function(next) {
 });
 
 Then(/^the item with id "([^"]*)" should exist$/, function(key, next) {
-  var params = { TableName: this.tableName, Key: { id: { S: key } } };
+  const params = { TableName: this.tableName, Key: { id: { S: key } } };
   this.request(null, "getItem", params, next);
 });
 
@@ -161,7 +161,7 @@ Then(/^it should have attribute "([^"]*)" containing "([^"]*)"$/, function(
 });
 
 When(/^I delete the table$/, function(next) {
-  var params = { TableName: this.tableName };
+  const params = { TableName: this.tableName };
   this.request(null, "deleteTable", params, next);
 });
 
@@ -177,9 +177,9 @@ Given(/^my first request is corrupted with CRC checking (ON|OFF)$/, function(
   toggle,
   callback
 ) {
-  var world = this;
+  const world = this;
   this.service.config.dynamoDbCrc32 = toggle == "ON" ? true : false;
-  var req = this.service.listTables();
+  const req = this.service.listTables();
   this.service.config.dynamoDbCrc32 = true;
   req.removeAllListeners("httpData");
   req.on("httpData", function(chunk, resp) {
@@ -209,8 +209,8 @@ Then(/^the request should( not)? be retried$/, function(retry, callback) {
 Given(/^all of my requests are corrupted with CRC checking ON$/, function(
   callback
 ) {
-  var world = this;
-  var req = this.service.listTables();
+  const world = this;
+  const req = this.service.listTables();
   req.removeAllListeners("httpData");
   req.on("httpData", function(chunk, resp) {
     resp.httpResponse.body = Buffer.from('{"invalid":"response"}');
@@ -244,7 +244,7 @@ Then(/^the request should( not)? fail with a CRC checking error$/, function(
 Given(
   /^I try to delete an item with key "([^"]*)" from table "([^"]*)"$/,
   function(key, table, callback) {
-    var params = { TableName: table, Key: { id: { S: key } } };
+    const params = { TableName: table, Key: { id: { S: key } } };
     this.request(null, "deleteItem", params, callback, false);
   }
 );

features/dynamodbstreams/step_definitions/dynamodbstreams.js

@@ -1,4 +1,4 @@
-var { DynamoDBStreams } = require("../../../clients/client-dynamodb-streams");
+const { DynamoDBStreams } = require("../../../clients/client-dynamodb-streams");
 const { Before } = require("cucumber");
 
 Before({ tags: "@dynamodbstreams" }, function(scenario, callback) {

features/ec2/step_definitions/ec2.js

@@ -1,4 +1,5 @@
-var { EC2 } = require("../../../clients/client-ec2");
+const { EC2 } = require("../../../clients/client-ec2");
+const { Before, Given, Then } = require("cucumber");
 
 /**
  * Waits for the volumeAvailable state by periodically calling the underlying
@@ -37,7 +38,6 @@ const waitForVolumeAvailable = (ec2, volumeId, callback) => {
   };
   checkForVolumeAvailable();
 };
-const { Before, Given, Then, When } = require("cucumber");
 
 Before({ tags: "@ec2" }, function(scenario, callback) {
   this.service = new EC2({});
@@ -76,12 +76,12 @@ Given(/^I describe the EC2 instance "([^"]*)"$/, function(
 Given(/^I attempt to copy an encrypted snapshot across regions$/, function(
   callback
 ) {
-  var self = this;
-  var volId, srcSnapId, dstSnapId, params;
-  var sourceRegion = "us-west-2";
-  var destRegion = "us-east-1";
-  var srcEc2 = new EC2({ region: sourceRegion });
-  var dstEc2 = new EC2({ region: destRegion });
+  const self = this;
+  let volId, srcSnapId, dstSnapId, params;
+  const sourceRegion = "us-west-2";
+  const destRegion = "us-east-1";
+  const srcEc2 = new EC2({ region: sourceRegion });
+  const dstEc2 = new EC2({ region: destRegion });
 
   function teardown() {
     if (volId) srcEc2.deleteVolume({ VolumeId: volId }).send();

features/ecr/step_definitions/ecr.js

@@ -1,4 +1,4 @@
-var { ECR } = require("../../../clients/client-ecr");
+const { ECR } = require("../../../clients/client-ecr");
 const { Before } = require("cucumber");
 
 Before({ tags: "@ecr" }, function(scenario, callback) {