chore(util-endpoints): updates to dynamic endpoint resolver (#3908)

Author: trivikr

packages/util-endpoints/src/resolveEndpoint.ts

@@ -1,10 +1,12 @@
+import { EndpointV2 } from "@aws-sdk/types";
+
 import { EndpointError, EndpointResolverOptions, RuleSetObject } from "./types";
 import { evaluateRules } from "./utils";
 
 /**
  * Resolves an endpoint URL by processing the endpoints ruleset and options.
  */
-export const resolveEndpoint = (ruleSetObject: RuleSetObject, options: EndpointResolverOptions) => {
+export const resolveEndpoint = (ruleSetObject: RuleSetObject, options: EndpointResolverOptions): EndpointV2 => {
   const { endpointParams, logger } = options;
   const { parameters, rules } = ruleSetObject;
 

packages/util-endpoints/src/utils/evaluateCondition.ts

@@ -2,7 +2,7 @@ import { ConditionObject, EndpointError, EvaluateOptions } from "../types";
 import { callFunction } from "./callFunction";
 
 export const evaluateCondition = ({ assign, ...fnArgs }: ConditionObject, options: EvaluateOptions) => {
-  if (assign && options.referenceRecord[assign]) {
+  if (assign && assign in options.referenceRecord) {
     throw new EndpointError(`'${assign}' is already defined in Reference Record.`);
   }
   const value = callFunction(fnArgs, options);

packages/util-endpoints/src/utils/evaluateRules.ts

@@ -1,9 +1,11 @@
+import { EndpointV2 } from "@aws-sdk/types";
+
 import { EndpointError, EvaluateOptions, RuleSetRules } from "../types";
 import { evaluateEndpointRule } from "./evaluateEndpointRule";
 import { evaluateErrorRule } from "./evaluateErrorRule";
 import { evaluateTreeRule } from "./evaluateTreeRule";
 
-export const evaluateRules = (rules: RuleSetRules, options: EvaluateOptions) => {
+export const evaluateRules = (rules: RuleSetRules, options: EvaluateOptions): EndpointV2 => {
   for (const rule of rules) {
     if (rule.type === "endpoint") {
       const endpointOrUndefined = evaluateEndpointRule(rule, options);

packages/util-endpoints/src/utils/evaluateTemplate.ts

@@ -1,4 +1,3 @@
-// Do not remove getAttr import. It's called during template evaluation.
 import { getAttr } from "../lib";
 import { EvaluateOptions } from "../types";