Skip to content

Commit 33f5ef6

Browse files
authored
chore(smithy-client): skip emitting warning for Node.js 12.x (#4127)
1 parent ffec8bd commit 33f5ef6

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

packages/smithy-client/src/emitWarningIfUnsupportedVersion.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
describe("emitWarningIfUnsupportedVersion", () => {
1+
describe.skip("emitWarningIfUnsupportedVersion", () => {
22
let emitWarningIfUnsupportedVersion;
33
const emitWarning = process.emitWarning;
44
const supportedVersion = "14.0.0";

packages/smithy-client/src/emitWarningIfUnsupportedVersion.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@ let warningEmitted = false;
99
export const emitWarningIfUnsupportedVersion = (version: string) => {
1010
if (version && !warningEmitted && parseInt(version.substring(1, version.indexOf("."))) < 14) {
1111
warningEmitted = true;
12-
process.emitWarning(
13-
`The AWS SDK for JavaScript (v3) will\n` +
14-
`no longer support Node.js ${version} on November 1, 2022.\n\n` +
15-
`To continue receiving updates to AWS services, bug fixes, and security\n` +
16-
`updates please upgrade to Node.js 14.x or later.\n\n` +
17-
`For details, please refer our blog post: https://a.co/48dbdYz`,
18-
`NodeDeprecationWarning`
19-
);
12+
// ToDo: Turn back warning for future Node.js version deprecation
13+
// process.emitWarning(
14+
// `The AWS SDK for JavaScript (v3) will\n` +
15+
// `no longer support Node.js ${version} on November 1, 2022.\n\n` +
16+
// `To continue receiving updates to AWS services, bug fixes, and security\n` +
17+
// `updates please upgrade to Node.js 14.x or later.\n\n` +
18+
// `For details, please refer our blog post: https://a.co/48dbdYz`,
19+
// `NodeDeprecationWarning`
20+
// );
2021
}
2122
};

0 commit comments

Comments
 (0)