chore: strictly parse xml booleans

JordonPhillips · JordonPhillips · commit 3b0ccf162b07 · 2021-06-23T15:57:29.000+02:00
diff --git a/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlMemberDeserVisitor.java b/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlMemberDeserVisitor.java
@@ -53,7 +53,8 @@ final class XmlMemberDeserVisitor extends DocumentMemberDeserVisitor {
 
     @Override
     public String booleanShape(BooleanShape shape) {
-        return getDataSource() + " == 'true'";
+        getContext().getWriter().addImport("parseBoolean", "__parseBoolean", "@aws-sdk/smithy-client");
+        return "parseBoolean(" + getDataSource() + ")";
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ final class XmlMemberDeserVisitor extends DocumentMemberDeserVisitor {`
`53`	`53`
`54`	`54`	`@Override`
`55`	`55`	`public String booleanShape(BooleanShape shape) {`
`56`		`- return getDataSource() + " == 'true'";`
	`56`	`+ getContext().getWriter().addImport("parseBoolean", "__parseBoolean", "@aws-sdk/smithy-client");`
	`57`	`+ return "parseBoolean(" + getDataSource() + ")";`
`57`	`58`	`}`
`58`	`59`
`59`	`60`	`@Override`