fix(middleware-sdk-s3): refactoring tests and getting result for status codes< 200 and >= 300

Author: Siddharth Srivastava

packages/middleware-sdk-s3/src/throw-200-exceptions.spec.ts

@@ -6,6 +6,7 @@ describe("throw200ExceptionsMiddlewareOptions", () => {
   const mockNextHandler = jest.fn();
   const mockStreamCollector = jest.fn();
   const mockUtf8Encoder = jest.fn();
+  const mockResponse = jest.fn();
   const mockConfig = {
     streamCollector: mockStreamCollector,
     utf8Encoder: mockUtf8Encoder,
@@ -15,13 +16,34 @@ describe("throw200ExceptionsMiddlewareOptions", () => {
     jest.clearAllMocks();
   });
 
-  describe("exceptions for code < 200 and >= 300", () => {
+  describe("tests for statusCode < 200 and >= 300", () => {
     mockStreamCollector.mockResolvedValue(Buffer.from(""));
     mockUtf8Encoder.mockReturnValue("");
-    it("throws an exception if code is less than 200", async () => {
+
+    it.each([199, 300])("results for statusCode %i", async (statusCode) => {
+      mockNextHandler.mockReturnValue({
+        response: mockResponse,
+        statusCode,
+        // headers: {},
+        // body: "",
+      });
+    });
+    const handler = throw200ExceptionsMiddleware(mockConfig)(mockNextHandler, {} as any);
+    const result = await handler({
+      input: {},
+      request: new HttpRequest({
+        hostname: "s3.us-east-1.amazonaws.com",
+      }),
+    });
+    expect(result.response).toBe(mockResponse);
+
+    it("should throw if response body is empty", async () => {
+      expect.assertions(3);
+      mockStreamCollector.mockResolvedValue(Buffer.from(""));
+      mockUtf8Encoder.mockReturnValue("");
       mockNextHandler.mockReturnValue({
         response: new HttpResponse({
-          statusCode: 199,
+          statusCode: 200,
           headers: {},
           body: "",
         }),
@@ -40,81 +62,34 @@ describe("throw200ExceptionsMiddlewareOptions", () => {
         expect(e.message).toEqual("S3 aborted request");
       }
     });
-    it("throws an exception if code is greater than or equal to 300", async () => {
+
+    it("should throw if response body contains Error tag", async () => {
+      const errorBody = `<?xml version="1.0" encoding="UTF-8"?>
+    <Error>
+      <Code>InternalError</Code>
+      <Message>We encountered an internal error. Please try again.</Message>
+      <RequestId>656c76696e6727732072657175657374</RequestId>
+      <HostId>Uuag1LuByRx9e6j5Onimru9pO4ZVKnJ2Qz7/C1NPcfTWAtRPfTaOFg==</HostId>
+    </Error>`;
+      mockStreamCollector.mockResolvedValue(Buffer.from(errorBody));
+      mockUtf8Encoder.mockReturnValue(errorBody);
       mockNextHandler.mockReturnValue({
         response: new HttpResponse({
-          statusCode: 300,
+          statusCode: 200,
           headers: {},
           body: "",
         }),
       });
       const handler = throw200ExceptionsMiddleware(mockConfig)(mockNextHandler, {} as any);
-      try {
-        await handler({
-          input: {},
-          request: new HttpRequest({
-            hostname: "s3.us-east-1.amazonaws.com",
-          }),
-        });
-      } catch (e) {
-        expect(e).toBeDefined();
-        expect(e.name).toEqual("InternalError");
-        expect(e.message).toEqual("S3 aborted request");
-      }
-    });
-  });
-  it("should throw if response body is empty", async () => {
-    expect.assertions(3);
-    mockStreamCollector.mockResolvedValue(Buffer.from(""));
-    mockUtf8Encoder.mockReturnValue("");
-    mockNextHandler.mockReturnValue({
-      response: new HttpResponse({
-        statusCode: 200,
-        headers: {},
-        body: "",
-      }),
-    });
-    const handler = throw200ExceptionsMiddleware(mockConfig)(mockNextHandler, {} as any);
-    try {
-      await handler({
+      const { response } = await handler({
         input: {},
         request: new HttpRequest({
           hostname: "s3.us-east-1.amazonaws.com",
         }),
       });
-    } catch (e) {
-      expect(e).toBeDefined();
-      expect(e.name).toEqual("InternalError");
-      expect(e.message).toEqual("S3 aborted request");
-    }
-  });
-
-  it("should throw if response body contains Error tag", async () => {
-    const errorBody = `<?xml version="1.0" encoding="UTF-8"?>
-    <Error>
-      <Code>InternalError</Code>
-      <Message>We encountered an internal error. Please try again.</Message>
-      <RequestId>656c76696e6727732072657175657374</RequestId>
-      <HostId>Uuag1LuByRx9e6j5Onimru9pO4ZVKnJ2Qz7/C1NPcfTWAtRPfTaOFg==</HostId>
-    </Error>`;
-    mockStreamCollector.mockResolvedValue(Buffer.from(errorBody));
-    mockUtf8Encoder.mockReturnValue(errorBody);
-    mockNextHandler.mockReturnValue({
-      response: new HttpResponse({
-        statusCode: 200,
-        headers: {},
-        body: "",
-      }),
-    });
-    const handler = throw200ExceptionsMiddleware(mockConfig)(mockNextHandler, {} as any);
-    const { response } = await handler({
-      input: {},
-      request: new HttpRequest({
-        hostname: "s3.us-east-1.amazonaws.com",
-      }),
+      expect(HttpResponse.isInstance(response)).toBe(true);
+      // @ts-ignore
+      expect(response.statusCode).toBeGreaterThanOrEqual(400);
     });
-    expect(HttpResponse.isInstance(response)).toBe(true);
-    // @ts-ignore
-    expect(response.statusCode).toBeGreaterThanOrEqual(400);
   });
 });