Skip to content

Commit 4962f21

Browse files
committed
chore(codegen): update comments in EndpointResolver
1 parent 6f20a32 commit 4962f21

File tree

1 file changed

+3
-3
lines changed
  • codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen

1 file changed

+3
-3
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/EndpointGenerator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ private void loadServiceEndpoints() {
9292

9393
for (Map.Entry<String, Node> entry : endpointMap.getStringMap().entrySet()) {
9494
ObjectNode config = entry.getValue().expectObjectNode();
95-
// TODO: Do not populate config if "deprecated" is present.
95+
// TODO: Do not populate config if "deprecated" is present, after fully switching to variants.
9696
if (config.containsMember("hostname") || config.containsMember("variants")) {
9797
String hostname = config.getStringMemberOrDefault("hostname", partition.hostnameTemplate);
9898
String resolvedHostname = getResolvedHostname(hostname, dnsSuffix, endpointPrefix, entry.getKey());
@@ -104,7 +104,7 @@ private void loadServiceEndpoints() {
104104
ArrayNode.fromNodes());
105105
ArrayNode defaultVariant = ArrayNode.fromNodes(getDefaultVariant(resolvedHostname));
106106

107-
// Populate hostname as the default variant.
107+
// Add resolved hostname as the default variant.
108108
config = config.withMember("variants", variants.merge(defaultVariant));
109109
endpoints.put(entry.getKey(), config);
110110
}
@@ -173,7 +173,7 @@ private void writeEndpointProviderFunction() {
173173

174174
private void writeEndpointSpecificResolver(String region, ObjectNode resolved) {
175175
writer.openBlock("$S: {", "},", region, () -> {
176-
// TODO: Remove population of hostname after switching to variants.
176+
// TODO: Remove hostname after fully switching to variants.
177177
String hostname = resolved.expectStringMember("hostname").getValue();
178178
writer.write("hostname: $S,", hostname);
179179

0 commit comments

Comments
 (0)