fix: use object for identifiers

Author: trivikr

packages/middleware-endpoint-discovery/src/getCacheKey.spec.ts

@@ -17,18 +17,15 @@ describe(getCacheKey.name, () => {
   });
 
   it("returns commandName and identifiers if passed", async () => {
-    const identifiers = new Map().set("key", "value");
-    const identifiersObj = { key: "value" };
+    const identifiers = { key: "value" };
     const cacheKey = await getCacheKey(commandName, config, { identifiers });
-    expect(cacheKey).toEqual(
-      JSON.stringify({ accessKeyId: mockCredentials.accessKeyId, commandName, identifiers: identifiersObj })
-    );
+    expect(cacheKey).toEqual(JSON.stringify({ accessKeyId: mockCredentials.accessKeyId, commandName, identifiers }));
   });
 
   it("returns same cache key irrespective of key order in identifiers", async () => {
-    const identifiers1 = new Map().set("key1", "value1").set("key2", "value2");
+    const identifiers1 = { key1: "value1", key2: "value2" };
     const cacheKey1 = await getCacheKey(commandName, config, { identifiers: identifiers1 });
-    const identifiers2 = new Map().set("key2", "value2").set("key1", "value1");
+    const identifiers2 = { key2: "value2", key1: "value1" };
     const cacheKey2 = await getCacheKey(commandName, config, { identifiers: identifiers2 });
     expect(cacheKey1).toStrictEqual(cacheKey2);
   });

packages/middleware-endpoint-discovery/src/getCacheKey.ts

@@ -7,7 +7,7 @@ export const getCacheKey = async (
   commandName: string,
   config: { credentials: Provider<Credentials> },
   options: {
-    identifiers?: Map<string, string>;
+    identifiers?: { [key: string]: string };
   }
 ) => {
   const { accessKeyId } = await config.credentials();
@@ -16,7 +16,7 @@ export const getCacheKey = async (
     ...(accessKeyId && { accessKeyId }),
     ...(identifiers && {
       commandName,
-      identifiers: Array.from(identifiers)
+      identifiers: Object.entries(identifiers)
         .sort()
         .reduce((acc, [key, value]) => ({ ...acc, [key]: value }), {}),
     }),

packages/middleware-endpoint-discovery/src/getEndpointDiscoveryCommandPlugin.ts

@@ -12,7 +12,7 @@ export const endpointDiscoveryMiddlewareOptions: FinalizeRequestHandlerOptions =
 
 export type EndpointDiscoveryMiddlewareConfig = {
   isDiscoveredEndpointRequired: boolean;
-  identifiers?: Map<string, string>;
+  identifiers?: { [key: string]: string };
 };
 
 export const getEndpointDiscoveryCommandPlugin = (