fix: address feedbacks

Co-authored-by: Trivikram Kamat <[email protected]>

Author: AllanZhengYP

packages/credential-provider-ini/src/index.ts

@@ -128,25 +128,23 @@ interface AssumeRoleWithProviderProfile extends Profile {
   credential_source: string;
 }
 
-const isAssumeRoleWithSourceProfile = (arg: any): arg is AssumeRoleWithSourceProfile =>
+const isAssumeRoleProfile = (arg: any) =>
   Boolean(arg) &&
   typeof arg === "object" &&
   typeof arg.role_arn === "string" &&
-  typeof arg.source_profile === "string" &&
-  typeof arg.credential_source === "undefined" &&
   ["undefined", "string"].indexOf(typeof arg.role_session_name) > -1 &&
   ["undefined", "string"].indexOf(typeof arg.external_id) > -1 &&
   ["undefined", "string"].indexOf(typeof arg.mfa_serial) > -1;
 
+const isAssumeRoleWithSourceProfile = (arg: any): arg is AssumeRoleWithSourceProfile =>
+  isAssumeRoleProfile(arg) &&
+  typeof arg.source_profile === "string" &&
+  typeof arg.credential_source === "undefined";
+
 const isAssumeRoleWithProviderProfile = (arg: any): arg is AssumeRoleWithProviderProfile =>
-  Boolean(arg) &&
-  typeof arg === "object" &&
-  typeof arg.role_arn === "string" &&
+  isAssumeRoleProfile(arg) &&
   typeof arg.credential_source === "string" &&
-  typeof arg.source_profile === "undefined" &&
-  ["undefined", "string"].indexOf(typeof arg.role_session_name) > -1 &&
-  ["undefined", "string"].indexOf(typeof arg.external_id) > -1 &&
-  ["undefined", "string"].indexOf(typeof arg.mfa_serial) > -1;
+  typeof arg.source_profile === "undefined";
 
 /**
  * Creates a credential provider that will read from ini files and supports