Skip to content

Commit 5c72a86

Browse files
committed
chore(codegen): include default value comment for service id
1 parent 962458d commit 5c72a86

File tree

1 file changed

+5
-2
lines changed
  • codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen

1 file changed

+5
-2
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsRuntimeConfig.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,10 @@ public void addConfigInterfaceFields(
7777
TypeScriptWriter writer
7878
) {
7979
if (isAwsService(settings, model)) {
80-
writer.writeDocs("Unique service identifier.\n@internal")
80+
ServiceShape service = settings.getService(model);
81+
String sdkId = service.getTrait(ServiceTrait.class).map(ServiceTrait::getSdkId)
82+
.orElse("");
83+
writer.writeDocs(String.format("Unique service identifier.%n@internal%n@default \"%s\"", sdkId))
8184
.write("serviceId?: string;\n");
8285
}
8386
if (isSigV4Service(settings, model)) {
@@ -106,7 +109,7 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
106109
writer.write("$S", serviceId);
107110
});
108111
} else {
109-
LOGGER.info("Cannot generate a serivce ID for the client because no aws.api#Service "
112+
LOGGER.info("Cannot generate a service ID for the client because no aws.api#Service "
110113
+ "trait was found on " + service.getId());
111114
}
112115
}

0 commit comments

Comments
 (0)