Skip to content

Commit 6043d79

Browse files
authored
fix(client-transcribe-streaming): add plugin only for operations with streaming trait (#6349)
1 parent 9836a09 commit 6043d79

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

clients/client-transcribe-streaming/src/TranscribeStreamingClient.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
} from "@aws-sdk/middleware-host-header";
1313
import { getLoggerPlugin } from "@aws-sdk/middleware-logger";
1414
import { getRecursionDetectionPlugin } from "@aws-sdk/middleware-recursion-detection";
15-
import { getTranscribeStreamingPlugin } from "@aws-sdk/middleware-sdk-transcribe-streaming";
1615
import {
1716
getUserAgentPlugin,
1817
resolveUserAgentConfig,
@@ -361,7 +360,6 @@ export class TranscribeStreamingClient extends __Client<
361360
}),
362361
})
363362
);
364-
this.middlewareStack.use(getTranscribeStreamingPlugin(this.config));
365363
this.middlewareStack.use(getHttpSigningPlugin(this.config));
366364
}
367365

clients/client-transcribe-streaming/src/commands/StartCallAnalyticsStreamTranscriptionCommand.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// smithy-typescript generated code
22
import { getEventStreamPlugin } from "@aws-sdk/middleware-eventstream";
3+
import { getTranscribeStreamingPlugin } from "@aws-sdk/middleware-sdk-transcribe-streaming";
34
import { getWebSocketPlugin } from "@aws-sdk/middleware-websocket";
45
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
56
import { getSerdePlugin } from "@smithy/middleware-serde";
@@ -248,6 +249,7 @@ export class StartCallAnalyticsStreamTranscriptionCommand extends $Command
248249
getWebSocketPlugin(config, {
249250
headerPrefix: "x-amzn-transcribe-",
250251
}),
252+
getTranscribeStreamingPlugin(config),
251253
];
252254
})
253255
.s("Transcribe", "StartCallAnalyticsStreamTranscription", {

clients/client-transcribe-streaming/src/commands/StartMedicalStreamTranscriptionCommand.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// smithy-typescript generated code
22
import { getEventStreamPlugin } from "@aws-sdk/middleware-eventstream";
3+
import { getTranscribeStreamingPlugin } from "@aws-sdk/middleware-sdk-transcribe-streaming";
34
import { getWebSocketPlugin } from "@aws-sdk/middleware-websocket";
45
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
56
import { getSerdePlugin } from "@smithy/middleware-serde";
@@ -229,6 +230,7 @@ export class StartMedicalStreamTranscriptionCommand extends $Command
229230
getWebSocketPlugin(config, {
230231
headerPrefix: "x-amzn-transcribe-",
231232
}),
233+
getTranscribeStreamingPlugin(config),
232234
];
233235
})
234236
.s("Transcribe", "StartMedicalStreamTranscription", {

clients/client-transcribe-streaming/src/commands/StartStreamTranscriptionCommand.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// smithy-typescript generated code
22
import { getEventStreamPlugin } from "@aws-sdk/middleware-eventstream";
3+
import { getTranscribeStreamingPlugin } from "@aws-sdk/middleware-sdk-transcribe-streaming";
34
import { getWebSocketPlugin } from "@aws-sdk/middleware-websocket";
45
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
56
import { getSerdePlugin } from "@smithy/middleware-serde";
@@ -253,6 +254,7 @@ export class StartStreamTranscriptionCommand extends $Command
253254
getWebSocketPlugin(config, {
254255
headerPrefix: "x-amzn-transcribe-",
255256
}),
257+
getTranscribeStreamingPlugin(config),
256258
];
257259
})
258260
.s("Transcribe", "StartStreamTranscription", {

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddTranscribeStreamingDependency.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import software.amazon.smithy.aws.traits.ServiceTrait;
2323
import software.amazon.smithy.codegen.core.SymbolProvider;
2424
import software.amazon.smithy.model.Model;
25+
import software.amazon.smithy.model.knowledge.EventStreamIndex;
26+
import software.amazon.smithy.model.shapes.OperationShape;
2527
import software.amazon.smithy.model.shapes.ServiceShape;
2628
import software.amazon.smithy.typescript.codegen.LanguageTarget;
2729
import software.amazon.smithy.typescript.codegen.TypeScriptSettings;
@@ -54,7 +56,7 @@ public List<RuntimeClientPlugin> getClientPlugins() {
5456
RuntimeClientPlugin.builder()
5557
.withConventions(AwsDependency.TRANSCRIBE_STREAMING_MIDDLEWARE.dependency,
5658
"TranscribeStreaming", RuntimeClientPlugin.Convention.HAS_MIDDLEWARE)
57-
.servicePredicate((m, s) -> isTranscribeStreaming(s))
59+
.operationPredicate((m, s, o) -> isTranscribeStreaming(s) && hasEventStreamInput(m, s, o))
5860
.build()
5961
);
6062
}
@@ -92,6 +94,11 @@ private static boolean isTranscribeStreaming(ServiceShape service) {
9294
String serviceId = service.getTrait(ServiceTrait.class).map(ServiceTrait::getSdkId).orElse("");
9395
return serviceId.equals("Transcribe Streaming");
9496
}
97+
98+
private static boolean hasEventStreamInput(Model model, ServiceShape service, OperationShape operation) {
99+
EventStreamIndex eventStreamIndex = EventStreamIndex.of(model);
100+
return eventStreamIndex.getInputInfo(operation).isPresent();
101+
}
95102
}
96103

97104

0 commit comments

Comments
 (0)