fix: address style suggestions--FP

Author: AllanZhengYP

clients/node/client-rds-data-node/RDSDataClient.ts

@@ -9,7 +9,7 @@ import {
 } from "./RDSDataConfiguration";
 import { RegionConfiguration, EndpointsConfig, ProtocolConfig } from '@aws-sdk/config-resolver';
 import { HttpOptions, MetadataBearer } from '@aws-sdk/types';
-import { SmithyClient } from "@aws-sdk/smithy-client";
+import { Client as SmithyClient } from "@aws-sdk/smithy-client";
 
 type InputTypesUnion = any;
 type OutputTypesUnion = MetadataBearer;

clients/node/client-rds-data-node/commands/ExecuteStatementCommand.ts

@@ -41,7 +41,7 @@ export class ExecuteStatementCommand extends Command<ExecuteStatementInput, Exec
     };
 
     return stack.resolve(
-      (request: FinalizeHandlerArguments<any>) => { return httpHandler.handle(request.request as HttpRequest, options || {}) },
+      (request: FinalizeHandlerArguments<any>) => httpHandler.handle(request.request as HttpRequest, options || {}),
       handlerExecutionContext
     );
   }

packages/smithy-client/src/client.ts

@@ -15,7 +15,7 @@ export type SmithyResolvedConfiguration<HandlerOptions> = SmithyConfiguration<
   HandlerOptions
 >;
 
-export class SmithyClient<
+export class Client<
   HandlerOptions = any,
   ClientInput extends object = any,
   ClientOutput extends MetadataBearer = any
@@ -31,7 +31,7 @@ export class SmithyClient<
   ) {
     const { middleware, step, priority, tags } = injectable;
     this.middlewareStack.add(
-      // @ts-ignore
+      // @ts-ignore -- Middleware and option type matching safety is enforced by InjectableMiddleware types
       middleware,
       {
         step: options.step || step,

packages/stream-collector-browser/src/index.ts

@@ -1,13 +1,12 @@
 import { StreamCollector } from "@aws-sdk/types";
 
-export const streamCollector: StreamCollector = function streamCollector(
+export const streamCollector: StreamCollector = (
   stream: Blob
-): Promise<Uint8Array> {
-  return new Promise<Uint8Array>((resolve, reject) => {
+): Promise<Uint8Array> =>
+  new Promise<Uint8Array>((resolve, reject) => {
     const reader = new FileReader();
     reader.onload = () => resolve(new Uint8Array(reader.result as ArrayBuffer));
     reader.onabort = () => reject(new Error("Read aborted"));
     reader.onerror = () => reject(reader.error);
     reader.readAsArrayBuffer(stream);
   });
-};

packages/stream-collector-node/src/index.ts

@@ -2,10 +2,10 @@ import { Readable } from "stream";
 import { StreamCollector } from "@aws-sdk/types";
 import { Collector } from "./collector";
 
-export const streamCollector: StreamCollector = function streamCollector(
+export const streamCollector: StreamCollector = (
   stream: Readable
-): Promise<Uint8Array> {
-  return new Promise((resolve, reject) => {
+): Promise<Uint8Array> =>
+  new Promise((resolve, reject) => {
     const collector = new Collector();
     stream.pipe(collector);
     stream.on("error", err => {
@@ -19,4 +19,3 @@ export const streamCollector: StreamCollector = function streamCollector(
       resolve(bytes);
     });
   });
-};