Skip to content

Commit 8a73c94

Browse files
committed
chore: add a comment to remove hostname after switching to variants
1 parent 42e7158 commit 8a73c94

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/EndpointGenerator.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ private void writePartitionHash() {
136136
writer.write("regionRegex: $S,", partition.regionRegex);
137137
OptionalUtils.ifPresentOrElse(partition.getPartitionEndpoint(),
138138
endpoint -> writer.write("endpoint: $S,", endpoint),
139+
// TODO: Remove population of hostname after switching to variants.
139140
() -> writer.write("hostname: $S,", partition.hostnameTemplate));
140141
List<Node> variants = partition.getVariants();
141142
if (!variants.isEmpty()) {
@@ -174,6 +175,7 @@ private void writeEndpointSpecificResolver(String region, ObjectNode resolved) {
174175
|| resolved.containsMember("hostname")
175176
|| resolved.containsMember("credentialScope")) {
176177
writer.openBlock("$S: {", "},", region, () -> {
178+
// TODO: Remove population of hostname after switching to variants.
177179
if (resolved.containsMember("hostname")) {
178180
String hostname = resolved.expectStringMember("hostname").getValue();
179181
writer.write("hostname: $S,", hostname);

packages/config-resolver/src/regionInfo/PartitionHash.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ export type PartitionHash = {
99
[key: string]: {
1010
regions: string[];
1111
regionRegex: string;
12+
// TODO: Remove hostname after fully switching to variants.
1213
hostname?: string;
1314
endpoint?: string;
1415
variants?: EndpointVariant[];

packages/config-resolver/src/regionInfo/RegionHash.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { EndpointVariant } from "./EndpointVariant";
66
*/
77
export type RegionHash = {
88
[key: string]: {
9+
// TODO: Remove hostname after fully switching to variants.
910
hostname?: string;
1011
variants?: EndpointVariant[];
1112
signingService?: string;

0 commit comments

Comments
 (0)