Skip to content

Commit 90fcc28

Browse files
committed
feat: use naming convention instead of namespace
1 parent e30bd0f commit 90fcc28

File tree

18 files changed

+205
-495
lines changed

18 files changed

+205
-495
lines changed

clients/node/client-rds-data-node/RDSDataClient.ts

Lines changed: 0 additions & 57 deletions
This file was deleted.

clients/node/client-rds-data-node/RdsDataServiceClient.ts

Lines changed: 30 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,27 @@ import {
1212
RollbackTransactionRequest,
1313
RollbackTransactionResponse
1414
} from "./models/index";
15-
import { Endpoints, ClientProtocol, Region } from "@aws-sdk/config-resolver";
16-
import { ContentLength } from "@aws-sdk/middleware-content-length";
17-
import { UserAgent } from "@aws-sdk/middleware-user-agent";
18-
import { Retry } from "@aws-sdk/middleware-retry";
19-
import { AwsAuth } from "@aws-sdk/middleware-signing";
20-
import { RDSDataRuntimeDependencies } from "./RDSDataConfiguration";
21-
import { RDSRuntimeConfiguration } from "./runtimeConfig";
2215
import {
23-
Client as SmithyClient,
24-
SmithyConfiguration,
25-
SmithyResolvedConfiguration
26-
} from "@aws-sdk/smithy-client";
16+
RdsDataServiceConfig,
17+
RdsDataServiceResolvedConfig
18+
} from "./RdsDtataServiceConfiguration";
19+
import {
20+
resolveEndpointsConfig,
21+
resolveClientProtocolConfig,
22+
resolveRegionConfig
23+
} from "@aws-sdk/config-resolver";
24+
import { getContentLengthPlugin } from "@aws-sdk/middleware-content-length";
25+
import {
26+
resolveUserAgentConfig,
27+
getUserAgentPlugin
28+
} from "@aws-sdk/middleware-user-agent";
29+
import { resolveRetryConfig, getRetryPlugin } from "@aws-sdk/middleware-retry";
30+
import {
31+
resolveAwsAuthConfig,
32+
getAwsAuthPlugin
33+
} from "@aws-sdk/middleware-signing";
34+
import { RDSRuntimeConfiguration } from "./runtimeConfig";
35+
import { Client as SmithyClient } from "@aws-sdk/smithy-client";
2736
import { HttpOptions as __HttpOptions } from "@aws-sdk/types";
2837

2938
export type ServiceInputTypes =
@@ -42,23 +51,6 @@ export type ServiceOutputTypes =
4251
| ExecuteStatementResponse
4352
| BatchExecuteStatementResponse;
4453

45-
export type RdsDataServiceConfig = SmithyConfiguration<__HttpOptions> &
46-
Region.Input &
47-
AwsAuth.Input &
48-
Endpoints.Input &
49-
Retry.Input &
50-
UserAgent.Input;
51-
52-
export type RdsDataServiceResolvedConfig = SmithyResolvedConfiguration<
53-
__HttpOptions
54-
> &
55-
Region.Resolved &
56-
AwsAuth.Resolved &
57-
Endpoints.Resolved &
58-
Retry.Resolved &
59-
UserAgent.Resolved &
60-
Required<RDSDataRuntimeDependencies>;
61-
6254
export class RdsDataService extends SmithyClient<
6355
__HttpOptions,
6456
ServiceInputTypes,
@@ -67,21 +59,21 @@ export class RdsDataService extends SmithyClient<
6759
readonly config: RdsDataServiceResolvedConfig;
6860

6961
constructor(configuration: RdsDataServiceConfig) {
70-
const _config_0 = ClientProtocol.resolveConfig({
62+
const _config_0 = resolveClientProtocolConfig({
7163
...RDSRuntimeConfiguration,
7264
...configuration
7365
});
74-
let _config_1 = Region.resolveConfig(_config_0);
75-
let _config_2 = AwsAuth.resolveConfig(_config_1);
76-
let _config_3 = Endpoints.resolveConfig(_config_2);
77-
let _config_4 = Retry.resolveConfig(_config_3);
78-
let _config_5 = UserAgent.resolveConfig(_config_4);
66+
let _config_1 = resolveRegionConfig(_config_0);
67+
let _config_2 = resolveAwsAuthConfig(_config_1);
68+
let _config_3 = resolveEndpointsConfig(_config_2);
69+
let _config_4 = resolveRetryConfig(_config_3);
70+
let _config_5 = resolveUserAgentConfig(_config_4);
7971
super(_config_5);
8072
this.config = _config_5;
81-
super.use(ContentLength.setMiddleware(this.config));
82-
super.use(AwsAuth.setMiddleware(this.config));
83-
super.use(Retry.setMiddleware(this.config));
84-
super.use(UserAgent.setMiddleware(this.config));
73+
this.middlewareStack.use(getContentLengthPlugin(this.config));
74+
this.middlewareStack.use(getAwsAuthPlugin(this.config));
75+
this.middlewareStack.use(getRetryPlugin(this.config));
76+
this.middlewareStack.use(getUserAgentPlugin(this.config));
8577
}
8678

8779
destroy(): void {}

clients/node/client-rds-data-node/RDSDataConfiguration.ts renamed to clients/node/client-rds-data-node/RdsDtataServiceConfiguration.ts

Lines changed: 32 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,22 @@
1-
import { AwsAuth, AwsAuthInput } from "@aws-sdk/middleware-signing";
2-
import { UserAgent, UserAgentInput } from "@aws-sdk/middleware-user-agent";
3-
import { Retry, RetryInput } from "@aws-sdk/middleware-retry";
41
import {
5-
Region,
6-
RegionInput,
7-
Endpoints,
8-
EndpointsInput,
9-
ClientProtocol,
10-
ClientProtocolInput
2+
AwsAuthConfigInput,
3+
AwsAuthConfigResolved
4+
} from "@aws-sdk/middleware-signing";
5+
import {
6+
UserAgentConfigInput,
7+
UserAgentConfigResolved
8+
} from "@aws-sdk/middleware-user-agent";
9+
import {
10+
RetryConfigInput,
11+
RetryConfigResolved
12+
} from "@aws-sdk/middleware-retry";
13+
import {
14+
RegionConfigInput,
15+
RegionConfigResolved,
16+
EndpointsConfigInput,
17+
EndpointsConfigResolved,
18+
ClientProtocolConfigInput,
19+
ClientProtocolConfigResolved
1120
} from "@aws-sdk/config-resolver";
1221
import {
1322
Credentials,
@@ -100,20 +109,20 @@ export interface RDSDataRuntimeDependencies {
100109
service?: string;
101110
}
102111

103-
export type RDSDataConfiguration = RDSDataRuntimeDependencies &
104-
AwsAuthInput &
105-
RegionInput &
106-
RetryInput &
107-
EndpointsInput &
108-
ClientProtocolInput &
109-
UserAgentInput;
112+
export type RdsDataServiceConfig = RDSDataRuntimeDependencies &
113+
AwsAuthConfigInput &
114+
RegionConfigInput &
115+
RetryConfigInput &
116+
EndpointsConfigInput &
117+
ClientProtocolConfigInput &
118+
UserAgentConfigInput;
110119

111-
export type RDSDataResolvedConfiguration = Required<
120+
export type RdsDataServiceResolvedConfig = Required<
112121
RDSDataRuntimeDependencies
113122
> &
114-
AwsAuth.Resolved &
115-
Region.Resolved &
116-
Retry.Resolved &
117-
Endpoints.Resolved &
118-
ClientProtocol.Resolved &
119-
UserAgent.Resolved;
123+
AwsAuthConfigResolved &
124+
RegionConfigResolved &
125+
RetryConfigResolved &
126+
EndpointsConfigResolved &
127+
ClientProtocolConfigResolved &
128+
UserAgentConfigResolved;

clients/node/client-rds-data-node/commands/ExecuteStatementCommand.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Command } from "@aws-sdk/smithy-client";
2-
import { serdePlugin } from "@aws-sdk/middleware-serde";
2+
import { getSerdePlugin } from "@aws-sdk/middleware-serde";
33
import {
44
HttpOptions,
55
Handler,
@@ -8,7 +8,7 @@ import {
88
MiddlewareStack,
99
SerdeContext
1010
} from "@aws-sdk/types";
11-
import { RDSDataResolvedConfiguration } from "../RDSDataConfiguration";
11+
import { RdsDataServiceResolvedConfig } from "../RdsDtataServiceConfiguration";
1212
import { HttpRequest, HttpResponse } from "@aws-sdk/protocol-http";
1313
import {
1414
executeStatementAwsRestJson1_1Serialize,
@@ -29,15 +29,15 @@ export class ExecuteStatementCommand extends Command<
2929

3030
resolveMiddleware(
3131
clientStack: MiddlewareStack<InputTypesUnion, OutputTypesUnion>,
32-
configuration: RDSDataResolvedConfiguration,
32+
configuration: RdsDataServiceResolvedConfig,
3333
options?: HttpOptions
3434
): Handler<ExecuteStatementRequest, ExecuteStatementResponse> {
3535
const {
3636
protocol: { handler }
3737
} = configuration;
3838

3939
this.middlewareStack.use(
40-
serdePlugin(configuration, this.serialize, this.deserialize)
40+
getSerdePlugin(configuration, this.serialize, this.deserialize)
4141
);
4242

4343
const stack = clientStack.concat(this.middlewareStack);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
export * from "./RdsDataServiceClient";
2-
export * from "./RDSDataConfiguration";
2+
export * from "./RdsDtataServiceConfiguration";
33
export * from "./commands/ExecuteStatementCommand";

clients/node/client-rds-data-node/runtimeConfig.browser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { fromUtf8, toUtf8 } from "@aws-sdk/util-utf8-browser";
99
import { fromBase64, toBase64 } from "@aws-sdk/util-base64-browser";
1010
import { defaultUserAgent } from "@aws-sdk/util-user-agent-browser";
1111
import { name, version } from "./package.json";
12-
import { RDSDataRuntimeDependencies } from "./RDSDataConfiguration";
12+
import { RDSDataRuntimeDependencies } from "./RdsDtataServiceConfiguration";
1313

1414
export const RDSRuntimeConfiguration: Required<RDSDataRuntimeDependencies> = {
1515
protocolDefaultProvider: handler => new RestJsonProtocol(handler),

clients/node/client-rds-data-node/runtimeConfig.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { fromUtf8, toUtf8 } from "@aws-sdk/util-utf8-node";
1010
import { fromBase64, toBase64 } from "@aws-sdk/util-base64-node";
1111
import { defaultUserAgent } from "@aws-sdk/util-user-agent-node";
1212
import { name, version } from "./package.json";
13-
import { RDSDataRuntimeDependencies } from "./RDSDataConfiguration";
13+
import { RDSDataRuntimeDependencies } from "./RdsDtataServiceConfiguration";
1414

1515
export const RDSRuntimeConfiguration: Required<RDSDataRuntimeDependencies> = {
1616
protocolDefaultProvider: handler => new RestJsonProtocol(handler),

packages/config-resolver/src/EndpointsConfig.ts

Lines changed: 42 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -14,51 +14,48 @@ export function normalizeEndpoint(
1414
return endpoint!;
1515
}
1616

17-
export namespace Endpoints {
18-
export interface Input {
19-
/**
20-
* The fully qualified endpoint of the webservice. This is only required when using a custom endpoint (for example, when using a local version of S3).
21-
*/
22-
endpoint?: string | Endpoint | Provider<Endpoint>;
17+
export interface EndpointsConfigInput {
18+
/**
19+
* The fully qualified endpoint of the webservice. This is only required when using a custom endpoint (for example, when using a local version of S3).
20+
*/
21+
endpoint?: string | Endpoint | Provider<Endpoint>;
2322

24-
/**
25-
* The endpoint provider to call if no endpoint is provided
26-
*/
27-
endpointProvider?: any;
23+
/**
24+
* The endpoint provider to call if no endpoint is provided
25+
*/
26+
endpointProvider?: any;
2827

29-
/**
30-
* Whether TLS is enabled for requests.
31-
*/
32-
tls?: boolean;
33-
}
34-
interface PreviouslyResolved {
35-
urlParser: UrlParser;
36-
region: Provider<string>;
37-
service: string;
38-
}
39-
export interface Resolved extends Required<Input> {
40-
endpoint: Provider<Endpoint>;
41-
}
42-
export function resolveConfig<T>(
43-
input: T & Input & PreviouslyResolved
44-
): T & Resolved {
45-
const tls = input.tls || true;
46-
const defaultProvider = (tls: boolean, region: string) => ({
47-
protocol: tls ? "https:" : "http:",
48-
path: "/",
49-
hostname: `${input.service}.${region}.amazonaws.com`
50-
});
51-
const endpointProvider = input.endpointProvider || defaultProvider;
52-
let endpoint: Provider<Endpoint> = input.endpoint
53-
? normalizeEndpoint(input.endpoint, input.urlParser)
54-
: () => input.region().then(region => endpointProvider(tls, region));
55-
return {
56-
...input,
57-
endpointProvider,
58-
endpoint,
59-
tls
60-
};
61-
}
28+
/**
29+
* Whether TLS is enabled for requests.
30+
*/
31+
tls?: boolean;
32+
}
33+
interface PreviouslyResolved {
34+
urlParser: UrlParser;
35+
region: Provider<string>;
36+
service: string;
37+
}
38+
export interface EndpointsConfigResolved
39+
extends Required<EndpointsConfigInput> {
40+
endpoint: Provider<Endpoint>;
41+
}
42+
export function resolveEndpointsConfig<T>(
43+
input: T & EndpointsConfigInput & PreviouslyResolved
44+
): T & EndpointsConfigResolved {
45+
const tls = input.tls || true;
46+
const defaultProvider = (tls: boolean, region: string) => ({
47+
protocol: tls ? "https:" : "http:",
48+
path: "/",
49+
hostname: `${input.service}.${region}.amazonaws.com`
50+
});
51+
const endpointProvider = input.endpointProvider || defaultProvider;
52+
let endpoint: Provider<Endpoint> = input.endpoint
53+
? normalizeEndpoint(input.endpoint, input.urlParser)
54+
: () => input.region().then(region => endpointProvider(tls, region));
55+
return {
56+
...input,
57+
endpointProvider,
58+
endpoint,
59+
tls
60+
};
6261
}
63-
//export separately for showing comment block in Intellisense
64-
export type EndpointsInput = Endpoints.Input;

0 commit comments

Comments
 (0)