Skip to content

Commit 94d0078

Browse files
committed
chore(codegen): generate H2 handler according to model
1 parent 7d9ae68 commit 94d0078

File tree

1 file changed

+6
-7
lines changed
  • codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen

1 file changed

+6
-7
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddHttp2Dependency.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,10 @@
1616
package software.amazon.smithy.aws.typescript.codegen;
1717

1818
import java.util.Collections;
19+
import java.util.List;
1920
import java.util.Map;
2021
import java.util.function.Consumer;
21-
import software.amazon.smithy.aws.traits.ServiceTrait;
22+
import software.amazon.smithy.aws.traits.protocols.AwsProtocolTrait;
2223
import software.amazon.smithy.codegen.core.SymbolProvider;
2324
import software.amazon.smithy.model.Model;
2425
import software.amazon.smithy.model.shapes.ServiceShape;
@@ -38,8 +39,7 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
3839
TypeScriptSettings settings,
3940
Model model,
4041
SymbolProvider symbolProvider,
41-
LanguageTarget target
42-
) {
42+
LanguageTarget target) {
4343
if (!isHttp2Applicable(settings.getService(model))) {
4444
return Collections.emptyMap();
4545
}
@@ -57,9 +57,8 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
5757
}
5858

5959
private static boolean isHttp2Applicable(ServiceShape service) {
60-
String serviceId = service.getTrait(ServiceTrait.class).map(ServiceTrait::getSdkId).orElse("");
61-
// TODO: Add "Kinesis" service to http2 applicable, but blocked by potential breaking change.
62-
// Reference: https://github.com/aws/aws-sdk-js-v3/issues/1206
63-
return ListUtils.of("Lex Runtime V2", "Transcribe Streaming").contains(serviceId);
60+
List<String> eventStreamFlag = service.getTrait(AwsProtocolTrait.class)
61+
.map(AwsProtocolTrait::getEventStreamHttp).orElse(ListUtils.of());
62+
return eventStreamFlag.contains("h2");
6463
}
6564
}

0 commit comments

Comments
 (0)