fix(middleware-sdk-s3-control): do not validate for FIPS in S3 Outposts

Author: trivikr

packages/middleware-sdk-s3-control/src/process-arnables-plugin/parse-outpost-arnables.ts

@@ -120,6 +120,7 @@ const validateOutpostsArn = (
     clientRegion,
     clientSigningRegion: signingRegion,
     useFipsEndpoint,
+    allowFipsRegion: true,
   });
   validateNoDualstack(useDualstackEndpoint);
 };

packages/middleware-sdk-s3-control/src/process-arnables-plugin/plugin.spec.ts

@@ -169,8 +169,8 @@ describe("getProcessArnablesMiddleware", () => {
       expect(context).toMatchObject({ signing_service: "s3-outposts", signing_region: "us-gov-east-1" });
     });
 
-    it("should validate when arn region is fips region", async () => {
-      expect.assertions(1);
+    it("should compute hostname for fips region", async () => {
+      expect.assertions(4);
       const clientRegion = "us-gov-east-1";
       const hostname = `s3-control.${clientRegion}.amazonaws.com`;
       const options = setupPluginOptions({
@@ -181,36 +181,14 @@ describe("getProcessArnablesMiddleware", () => {
       });
       const stack = getStack(hostname, options);
       const handler = stack.resolve((() => {}) as any, {});
-      try {
-        await handler({
-          input: {
-            Name: "arn:aws-us-gov:s3-outposts:fips-us-gov-east-1:123456789012:outpost:op-01234567890123456:accesspoint:myaccesspoint",
-          },
-        });
-      } catch (e) {
-        expect(e.message).toContain("FIPS region is not supported");
-      }
-    });
-
-    it("should update endpoint, headers and context correctly if client is fips region", async () => {
-      expect.assertions(4);
-      const clientRegion = "fip-us-gov-east-1";
-      const hostname = `s3-control.${clientRegion}.amazonaws.com`;
-      const options = setupPluginOptions({
-        region: clientRegion,
-        useArnRegion: true,
-        regionInfoProvider: () => Promise.resolve({ hostname, partition: "aws-us-gov" }),
-      });
-      const stack = getStack(hostname, options);
-      const handler = stack.resolve((() => {}) as any, {});
       const {
         output: { request, context, input },
       } = (await handler({
         input: {
           Name: "arn:aws-us-gov:s3-outposts:us-gov-east-1:123456789012:outpost:op-01234567890123456:accesspoint:myaccesspoint",
         },
       })) as any;
-      expect(request.hostname).toBe("s3-outposts.us-gov-east-1.amazonaws.com");
+      expect(request.hostname).toBe("s3-outposts-fips.us-gov-east-1.amazonaws.com");
       expect(request.headers).toMatchObject({ "x-amz-outpost-id": "op-01234567890123456" });
       expect(input.AccountId).toBe("123456789012");
       expect(context).toMatchObject({ signing_service: "s3-outposts", signing_region: "us-gov-east-1" });
@@ -391,8 +369,8 @@ describe("getProcessArnablesMiddleware", () => {
       expect(context).toMatchObject({ signing_service: "s3-outposts", signing_region: "us-gov-east-1" });
     });
 
-    it("should validate when arn region is fips region", async () => {
-      expect.assertions(1);
+    it("should compute hostname for fips region", async () => {
+      expect.assertions(4);
       const clientRegion = "us-gov-east-1";
       const hostname = `s3-control.${clientRegion}.amazonaws.com`;
       const options = setupPluginOptions({
@@ -403,16 +381,17 @@ describe("getProcessArnablesMiddleware", () => {
       });
       const stack = getStack(hostname, options);
       const handler = stack.resolve((() => {}) as any, {});
-      try {
-        await handler({
-          input: {
-            Bucket:
-              "arn:aws-us-gov:s3-outposts:fips-us-gov-east-1:123456789012:outpost:op-01234567890123456:bucket:mybucket",
-          },
-        });
-      } catch (e) {
-        expect(e.message).toContain("FIPS region is not supported");
-      }
+      const {
+        output: { request, context, input },
+      } = (await handler({
+        input: {
+          Bucket: "arn:aws-us-gov:s3-outposts:us-gov-east-1:123456789012:outpost:op-01234567890123456:bucket:mybucket",
+        },
+      })) as any;
+      expect(request.hostname).toBe("s3-outposts-fips.us-gov-east-1.amazonaws.com");
+      expect(request.headers).toMatchObject({ "x-amz-outpost-id": "op-01234567890123456" });
+      expect(input.AccountId).toBe("123456789012");
+      expect(context).toMatchObject({ signing_service: "s3-outposts", signing_region: "us-gov-east-1" });
     });
 
     it("should update endpoint, headers and context correctly if client is fips region", async () => {