chore: use in operator instead of Object.hasOwnProperty

trivikr · trivikr · commit a8739fdfe67a · 2021-10-27T21:37:39.000Z
diff --git a/packages/node-config-provider/src/booleanSelector.ts b/packages/node-config-provider/src/booleanSelector.ts
@@ -4,7 +4,7 @@ export enum SelectorType {
 }
 
 export const booleanSelector = (obj: { [key: string]: string }, key: string, type: SelectorType) => {
-  if (!Object.prototype.hasOwnProperty.call(obj, key)) return undefined;
+  if (!(key in obj)) return undefined;
   if (obj[key] === "true") return true;
   if (obj[key] === "false") return false;
   throw new Error(`Cannot load ${type} "${key}". Expected "true" or "false", got ${obj[key]}.`);

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ export enum SelectorType {`
`4`	`4`	`}`
`5`	`5`
`6`	`6`	`export const booleanSelector = (obj: { [key: string]: string }, key: string, type: SelectorType) => {`
`7`		`- if (!Object.prototype.hasOwnProperty.call(obj, key)) return undefined;`
	`7`	`+ if (!(key in obj)) return undefined;`
`8`	`8`	`if (obj[key] === "true") return true;`
`9`	`9`	`if (obj[key] === "false") return false;`
`10`	`10`	throw new Error(`Cannot load ${type} "${key}". Expected "true" or "false", got ${obj[key]}.`);