Skip to content

Commit a9e0c6f

Browse files
committed
chore: update protocol tests
1 parent f18e5d0 commit a9e0c6f

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,11 @@ private static boolean filterProtocolTests(
312312
return true;
313313
}
314314

315+
// TODO: Remove when upstream tests update to serialize empty headers.
316+
if (testCase.getId().contains("NullAndEmptyHeaders")) {
317+
return true;
318+
}
319+
315320
if (testCase.getTags().contains("defaults")) {
316321
return true;
317322
}

private/aws-protocoltests-restjson/test/functional/restjson1.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6719,7 +6719,7 @@ it("RestJsonNoInputAndOutputNoPayload:Response", async () => {
67196719
/**
67206720
* Do not send null values, empty strings, or empty lists over the wire in headers
67216721
*/
6722-
it("RestJsonNullAndEmptyHeaders:Request", async () => {
6722+
it.skip("RestJsonNullAndEmptyHeaders:Request", async () => {
67236723
const client = new RestJsonProtocolClient({
67246724
...clientParams,
67256725
requestHandler: new RequestSerializationTestHandler(),

private/aws-protocoltests-restxml/test/functional/restxml.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3735,7 +3735,7 @@ it("NoInputAndOutput:Response", async () => {
37353735
/**
37363736
* Do not send null values, empty strings, or empty lists over the wire in headers
37373737
*/
3738-
it("NullAndEmptyHeaders:Request", async () => {
3738+
it.skip("NullAndEmptyHeaders:Request", async () => {
37393739
const client = new RestXmlProtocolClient({
37403740
...clientParams,
37413741
requestHandler: new RequestSerializationTestHandler(),

private/aws-restjson-server/test/functional/restjson1.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27857,7 +27857,7 @@ it("RestJsonNoInputAndOutputWithJson:ServerResponse", async () => {
2785727857
/**
2785827858
* Do not send null or empty headers
2785927859
*/
27860-
it("RestJsonNullAndEmptyHeaders:ServerResponse", async () => {
27860+
it.skip("RestJsonNullAndEmptyHeaders:ServerResponse", async () => {
2786127861
class TestService implements Partial<RestJsonService<{}>> {
2786227862
NullAndEmptyHeadersServer(input: any, ctx: {}): Promise<NullAndEmptyHeadersServerServerOutput> {
2786327863
const response = {

0 commit comments

Comments
 (0)