Skip to content

Commit b4ef84b

Browse files
authored
test(eventstream-handler-node): fix test broken in Node14 (#1221)
* test(eventstream-handler-node): fix test broken in Node14 * test(eventstream-handler-node): fix test in Node14
1 parent 5ac8973 commit b4ef84b

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

packages/eventstream-handler-node/src/EventStreamPayloadHandler.spec.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ describe("EventStreamPayloadHandler", () => {
3939
).rejects.toThrow("Eventstream payload must be a Readable stream.");
4040
});
4141

42-
it("should close the request payload if downstream middleware throws", async () => {
42+
it("should close the request payload if downstream middleware throws", async done => {
43+
expect.assertions(2);
4344
(mockNextHandler as any).mockImplementationOnce(() =>
4445
Promise.reject(new Error())
4546
);
@@ -61,9 +62,11 @@ describe("EventStreamPayloadHandler", () => {
6162
expect(error instanceof Error).toBe(true);
6263
//Expect stream is closed
6364
//Ref: should use writableEnded when bumped to Node 13+
64-
expect(() => {
65-
mockRequest.body.write("");
66-
}).toThrowError("write after end");
65+
(mockRequest.body as PassThrough).on("error", err => {
66+
expect(err.message).toEqual("write after end");
67+
done();
68+
});
69+
mockRequest.body.write("This should be allowed to write.");
6770
});
6871

6972
it("should call event signer with request signature from signing middleware", async () => {

0 commit comments

Comments
 (0)