chore: codegen to remove variables from serializeMap

Author: trivikr

clients/client-s3-control/protocols/Aws_restXml.ts

@@ -2622,8 +2622,7 @@ const serializeAws_restXmlS3UserMetadata = (
   input: { [key: string]: string },
   context: __SerdeContext
 ): any => {
-  const collectedNodes: any = [];
-  Object.keys(input).forEach(key => {
+  return Object.keys(input).map(key => {
     const entryNode = new __XmlNode("entry");
     const keyNode = new __XmlNode("NonEmptyMaxLength1024String")
       .addChildNode(new __XmlText(key))
@@ -2633,9 +2632,8 @@ const serializeAws_restXmlS3UserMetadata = (
       new __XmlText(input[key])
     );
     entryNode.addChildNode(node.withName("value"));
-    collectedNodes.push(entryNode);
+    return entryNode;
   });
-  return collectedNodes;
 };
 
 const serializeAws_restXmlVpcConfiguration = (

protocol_tests/aws-restxml/protocols/Aws_restXml.ts

@@ -4115,8 +4115,7 @@ const serializeAws_restXmlFlattenedXmlMapWithXmlNameInputOutputMap = (
   input: { [key: string]: string },
   context: __SerdeContext
 ): any => {
-  const collectedNodes: any = [];
-  Object.keys(input).forEach(key => {
+  return Object.keys(input).map(key => {
     const entryNode = new __XmlNode("entry");
     const keyNode = new __XmlNode("String")
       .addChildNode(new __XmlText(key))
@@ -4126,9 +4125,8 @@ const serializeAws_restXmlFlattenedXmlMapWithXmlNameInputOutputMap = (
       new __XmlText(input[key])
     );
     entryNode.addChildNode(node.withName("V"));
-    collectedNodes.push(entryNode);
+    return entryNode;
   });
-  return collectedNodes;
 };
 
 const serializeAws_restXmlNestedPayload = (
@@ -4300,36 +4298,32 @@ const serializeAws_restXmlXmlMapsInputOutputMap = (
   input: { [key: string]: GreetingStruct },
   context: __SerdeContext
 ): any => {
-  const collectedNodes: any = [];
-  Object.keys(input).forEach(key => {
+  return Object.keys(input).map(key => {
     const entryNode = new __XmlNode("entry");
     const keyNode = new __XmlNode("String")
       .addChildNode(new __XmlText(key))
       .withName("key");
     entryNode.addChildNode(keyNode);
     const node = serializeAws_restXmlGreetingStruct(input[key], context);
     entryNode.addChildNode(node.withName("value"));
-    collectedNodes.push(entryNode);
+    return entryNode;
   });
-  return collectedNodes;
 };
 
 const serializeAws_restXmlXmlMapsXmlNameInputOutputMap = (
   input: { [key: string]: GreetingStruct },
   context: __SerdeContext
 ): any => {
-  const collectedNodes: any = [];
-  Object.keys(input).forEach(key => {
+  return Object.keys(input).map(key => {
     const entryNode = new __XmlNode("entry");
     const keyNode = new __XmlNode("String")
       .addChildNode(new __XmlText(key))
       .withName("Attribute");
     entryNode.addChildNode(keyNode);
     const node = serializeAws_restXmlGreetingStruct(input[key], context);
     entryNode.addChildNode(node.withName("Setting"));
-    collectedNodes.push(entryNode);
+    return entryNode;
   });
-  return collectedNodes;
 };
 
 const serializeAws_restXmlXmlNamespaceNested = (
@@ -4399,8 +4393,7 @@ const serializeAws_restXmlFooEnumMap = (
   input: { [key: string]: FooEnum | string },
   context: __SerdeContext
 ): any => {
-  const collectedNodes: any = [];
-  Object.keys(input).forEach(key => {
+  return Object.keys(input).map(key => {
     const entryNode = new __XmlNode("entry");
     const keyNode = new __XmlNode("String")
       .addChildNode(new __XmlText(key))
@@ -4410,9 +4403,8 @@ const serializeAws_restXmlFooEnumMap = (
       new __XmlText(input[key])
     );
     entryNode.addChildNode(node.withName("value"));
-    collectedNodes.push(entryNode);
+    return entryNode;
   });
-  return collectedNodes;
 };
 
 const serializeAws_restXmlFooEnumSet = (