Skip to content

Commit b58c89e

Browse files
committed
chore: destroy session on sessionTimeout
1 parent 05673bb commit b58c89e

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

packages/node-http-handler/src/node-http2-handler.spec.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -343,12 +343,11 @@ describe(NodeHttp2Handler.name, () => {
343343
const authority = `${protocol}//${hostname}:${port}`;
344344
// @ts-ignore: access private property
345345
const session: ClientHttp2Session = nodeH2Handler.sessionList[0];
346-
expect(session.closed).toBe(false);
346+
expect(session.destroyed).toBe(false);
347347
// @ts-ignore: access private property
348348
expect(nodeH2Handler.sessionCache.get(authority)).toBeDefined();
349349
setTimeout(() => {
350-
expect(session.closed).toBe(true);
351-
expect(session.destroyed).toBe(false);
350+
expect(session.destroyed).toBe(true);
352351
// @ts-ignore: access private property
353352
expect(nodeH2Handler.sessionCache.get(authority)).not.toBeDefined();
354353
done();
@@ -361,11 +360,9 @@ describe(NodeHttp2Handler.name, () => {
361360

362361
// @ts-ignore: access private property
363362
const session: ClientHttp2Session = nodeH2Handler.sessionList[0];
364-
// When disableSessionCache:true, session is closed as soon as request gets response.
365-
expect(session.closed).toBe(true);
363+
expect(session.destroyed).toBe(false);
366364
setTimeout(() => {
367-
expect(session.closed).toBe(true);
368-
expect(session.destroyed).toBe(false);
365+
expect(session.destroyed).toBe(true);
369366
done();
370367
}, sessionTimeout + 100);
371368
});

packages/node-http-handler/src/node-http2-handler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export class NodeHttp2Handler implements HttpHandler {
158158
const sessionTimeout = this.sessionTimeout;
159159
if (sessionTimeout) {
160160
newSession.setTimeout(sessionTimeout, () => {
161-
newSession.close();
161+
this.destroySession(newSession);
162162
});
163163
}
164164

0 commit comments

Comments
 (0)