chore: clear connections array on destroy

Author: trivikr

packages/node-http-handler/src/node-http2-handler.spec.ts

@@ -219,18 +219,22 @@ describe(NodeHttp2Handler.name, () => {
     });
 
     describe("destroy", () => {
-      it("destroys sessions and clears connectionPool", async () => {
+      it("destroys session and clears connectionPool", async () => {
         await nodeH2Handler.handle(new HttpRequest(getMockReqOptions()), {});
 
         // @ts-ignore: access private property
-        const session: ClientHttp2Session = nodeH2Handler.connectionPool.get(`${protocol}//${hostname}:${port}`);
+        const session: ClientHttp2Session = nodeH2Handler.connections[0];
 
         // @ts-ignore: access private property
         expect(nodeH2Handler.connectionPool.size).toBe(1);
+        // @ts-ignore: access private property
+        expect(nodeH2Handler.connections.length).toBe(1);
         expect(session.destroyed).toBe(false);
         nodeH2Handler.destroy();
         // @ts-ignore: access private property
         expect(nodeH2Handler.connectionPool.size).toBe(0);
+        // @ts-ignore: access private property
+        expect(nodeH2Handler.connections.length).toBe(0);
         expect(session.destroyed).toBe(true);
       });
     });
@@ -429,5 +433,22 @@ describe(NodeHttp2Handler.name, () => {
         mockH2Server2.close();
       });
     });
+
+    describe("destroy", () => {
+      it("destroys session and clears connections", async () => {
+        await nodeH2Handler.handle(new HttpRequest(getMockReqOptions()), {});
+
+        // @ts-ignore: access private property
+        const session: ClientHttp2Session = nodeH2Handler.connections[0];
+
+        // @ts-ignore: access private property
+        expect(nodeH2Handler.connections.length).toBe(1);
+        expect(session.destroyed).toBe(false);
+        nodeH2Handler.destroy();
+        // @ts-ignore: access private property
+        expect(nodeH2Handler.connections.length).toBe(0);
+        expect(session.destroyed).toBe(true);
+      });
+    });
   });
 });

packages/node-http-handler/src/node-http2-handler.ts

@@ -50,7 +50,7 @@ export class NodeHttp2Handler implements HttpHandler {
   }
 
   destroy(): void {
-    this.connections.forEach(this.destroySession);
+    this.connections.forEach((session) => this.destroySession(session));
     this.connectionPool.clear();
   }
 
@@ -199,6 +199,7 @@ export class NodeHttp2Handler implements HttpHandler {
     if (!session.destroyed) {
       session.destroy();
     }
+    this.connections = this.connections.filter((s) => s !== session);
   }
 
   /**