test(s3): add integration test for s3 mrap (#3764)

* test(s3): add integration test for s3 mrap

* fix: nits and typo

Co-authored-by: Trivikram Kamat <[email protected]>

Author: AllanZhengYP

clients/client-s3/karma.conf.js

@@ -41,7 +41,7 @@ module.exports = function (config) {
       plugins: [new webpack.NormalModuleReplacementPlugin(/\.\/runtimeConfig$/, "./runtimeConfig.browser")],
       devtool: "inline-source-map",
     },
-    envPreprocessor: ["AWS_SMOKE_TEST_REGION", "AWS_SMOKE_TEST_BUCKET"],
+    envPreprocessor: ["AWS_SMOKE_TEST_REGION", "AWS_SMOKE_TEST_BUCKET", "AWS_SMOKE_TEST_MRAP_ARN"],
     plugins: [
       "@aws-sdk/karma-credential-loader",
       "karma-chrome-launcher",

clients/client-s3/test/e2e/S3.ispec.ts

@@ -17,6 +17,7 @@ const region: string | undefined = (globalThis as any).defaultRegion || process?
 const credentials: Credentials | undefined = (globalThis as any).credentials || undefined;
 const isBrowser: boolean | undefined = (globalThis as any).isBrowser || false;
 const Bucket = (globalThis as any)?.window?.__env__?.AWS_SMOKE_TEST_BUCKET || process?.env?.AWS_SMOKE_TEST_BUCKET;
+const mrapArn = (globalThis as any)?.window?.__env__?.AWS_SMOKE_TEST_MRAP_ARN || process?.env?.AWS_SMOKE_TEST_MRAP_ARN;
 
 let Key = `${Date.now()}`;
 
@@ -288,4 +289,34 @@ esfuture,29`;
       expect(events[2].End).to.be.exist;
     });
   });
+
+  describe("Multi-region access point", () => {
+    before(async () => {
+      Key = `${Date.now()}`;
+      await client.putObject({ Bucket, Key, Body: "foo" });
+    });
+    after(async () => {
+      await client.deleteObject({ Bucket, Key });
+    });
+    if (isBrowser) {
+      it("should throw for aws-crt no available in browser", async () => {
+        try {
+          await client.listObjects({
+            Bucket: mrapArn,
+          });
+          expect.fail("MRAP call in browser should throw");
+        } catch (e) {
+          expect(e.message).include("only available in Node.js");
+        }
+      });
+    } else {
+      it("should succeed with valid MRAP ARN", async () => {
+        const result = await client.listObjects({
+          Bucket: mrapArn,
+        });
+        expect(result.$metadata.httpStatusCode).to.equal(200);
+        expect(result.Contents).to.be.instanceOf(Array);
+      });
+    }
+  });
 });

package.json

@@ -12,7 +12,7 @@
     "build:clients:since:release": "yarn build:packages && lerna run build $(lerna changed | grep -e '@aws-sdk/[client|lib]-*' | sed 's/^/ --scope /' | tr '\n' ' ')",
     "build:crypto-dependencies": "lerna run --scope '@aws-sdk/{types,util-utf8-browser,util-locate-window,hash-node}' --include-dependencies build",
     "build:docs": "typedoc",
-    "build:e2e": "yarn build:crypto-dependencies && lerna run --scope '@aws-sdk/{client-cloudformation,karma-credential-loader}' --include-dependencies build",
+    "build:e2e": "yarn build:crypto-dependencies && lerna run --scope '@aws-sdk/{client-cloudformation,karma-credential-loader,client-s3-control,client-sts}' --include-dependencies build",
     "build:packages": "lerna run build --ignore '@aws-sdk/client-*' --ignore '@aws-sdk/aws-*' --ignore '@aws-sdk/lib-*' --include-dependencies",
     "build:protocols": "yarn build:crypto-dependencies && lerna run --scope '@aws-sdk/aws-protocoltests-*' --include-dependencies build",
     "build:server-protocols": "yarn build:crypto-dependencies && lerna run --scope '@aws-sdk/*-server' --include-dependencies build",

tests/e2e/IntegTestResourcesStack.template.json

@@ -69,6 +69,17 @@
       "Metadata": {
         "aws:cdk:path": "IntegTestResourcesStack/IntegTestBucket/Resource"
       }
+    },
+    "MultiregionAccessPoint": {
+      "Type": "AWS::S3::MultiRegionAccessPoint",
+      "Properties": {
+        "Name": "v3-sdk-integration-test-001",
+        "Regions": [
+          {
+            "Bucket": { "Ref": "IntegTestBucketA93771AE" }
+          }
+        ]
+      }
     }
   }
 }

tests/e2e/get-integ-test-resources.js

@@ -1,19 +1,21 @@
 const { readFileSync } = require("fs");
 const { join } = require("path");
+const { STSClient, GetCallerIdentityCommand } = require("../../clients/client-sts");
 const { CloudFormationClient, DescribeStackResourcesCommand } = require("../../clients/client-cloudformation");
+const { S3ControlClient, ListMultiRegionAccessPointsCommand } = require("../../clients/client-s3-control");
 const { ensureTestStack } = require("./ensure-test-stack");
 
 exports.getIntegTestResources = async () => {
-  const client = new CloudFormationClient({ logger: console });
-  const region = await client.config.region();
+  const cloudformation = new CloudFormationClient({ logger: console });
+  const region = await cloudformation.config.region();
   const stackName = "SdkReleaseV3IntegTestResourcesStack";
 
   await ensureTestStack(
-    client,
+    cloudformation,
     stackName,
     readFileSync(join(__dirname, "IntegTestResourcesStack.template.json"), { encoding: "utf-8" })
   );
-  const { StackResources: stackResources } = await client.send(
+  const { StackResources: stackResources } = await cloudformation.send(
     new DescribeStackResourcesCommand({ StackName: stackName })
   );
 
@@ -26,9 +28,21 @@ exports.getIntegTestResources = async () => {
     (resource) => resource.ResourceType === "AWS::S3::Bucket" && resource.LogicalResourceId.indexOf("IntegTest") === 0
   )[0].PhysicalResourceId;
 
+  const multiRegionAccessPointName = stackResources.filter(
+    (resource) => resource.ResourceType === "AWS::S3::MultiRegionAccessPoint"
+  )[0].PhysicalResourceId;
+
+  const sts = new STSClient({ logger: console });
+  const { Account: AccountId } = await sts.send(new GetCallerIdentityCommand({}));
+  const s3Control = new S3ControlClient({ logger: console });
+  const { AccessPoints } = await s3Control.send(new ListMultiRegionAccessPointsCommand({ AccountId }));
+  const { Alias } = AccessPoints.find((accesspoint) => accesspoint.Name === multiRegionAccessPointName);
+  const mrapArn = `arn:aws:s3::${AccountId}:accesspoint/${Alias}`;
+
   return {
     AWS_SMOKE_TEST_REGION: region,
     AWS_SMOKE_TEST_IDENTITY_POOL_ID: identityPoolId,
     AWS_SMOKE_TEST_BUCKET: bucketName,
+    AWS_SMOKE_TEST_MRAP_ARN: mrapArn,
   };
 };