Skip to content

Commit c85af6d

Browse files
committed
fix(eventstream-handler-node): verify stream is closed by reading writableEnded
1 parent e9adc0a commit c85af6d

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

packages/eventstream-handler-node/src/EventStreamPayloadHandler.spec.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ describe(EventStreamPayloadHandler.name, () => {
4343
it("should close the request payload if downstream middleware throws", async () => {
4444
const mockError = new Error("mockError");
4545
(mockNextHandler as any).mockImplementationOnce(() => Promise.reject(mockError));
46+
4647
const handler = new EventStreamPayloadHandler({
4748
eventSigner: () => Promise.resolve(mockSigner),
4849
utf8Decoder: mockUtf8Decoder,
@@ -61,13 +62,7 @@ describe(EventStreamPayloadHandler.name, () => {
6162
}
6263

6364
// Expect stream is closed
64-
// Ref: should use writableEnded when bumped to Node 13+
65-
(mockRequest.body as PassThrough).on("error", (err) => {
66-
expect(err.message).toEqual("write after end");
67-
});
68-
69-
mockRequest.body.write("This should be allowed to write.");
70-
return await once(mockRequest.body, "error");
65+
expect(mockRequest.body.writableEnded).toEqual(true);
7166
});
7267

7368
it("should call event signer with request signature from signing middleware", async () => {

0 commit comments

Comments
 (0)