Skip to content

Commit c85f9db

Browse files
committed
fix(config-resolver): check for dot before and after regionRegex match
1 parent c6076d2 commit c85f9db

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/config-resolver/src/regionInfo/getResolvedSigningRegion.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ describe(getResolvedSigningRegion.name, () => {
5050

5151
it("returns region from hostname is signingRegion is not present", () => {
5252
(isFipsRegion as jest.Mock).mockReturnValueOnce(true);
53-
const matchSpy = jest.spyOn(String.prototype, "match").mockReturnValueOnce([mockSigningRegion]);
53+
const matchSpy = jest.spyOn(String.prototype, "match").mockReturnValueOnce([`.${mockSigningRegion}.`]);
5454

5555
expect(getResolvedSigningRegion(mockRegion, mockOptions)).toEqual(mockSigningRegion);
5656
expect(matchSpy).toHaveBeenCalledTimes(1);

packages/config-resolver/src/regionInfo/getResolvedSigningRegion.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ export const getResolvedSigningRegion = (
1313
if (signingRegion) {
1414
return signingRegion;
1515
} else if (isFipsRegion(region)) {
16-
const regionRegexJs = regionRegex.replace("\\\\", "\\").replace(/^\^/g, "").replace(/\$$/g, "");
16+
const regionRegexJs = regionRegex.replace("\\\\", "\\").replace(/^\^/g, ".").replace(/\$$/g, ".");
1717
const regionRegexmatchArray = hostname.match(regionRegexJs);
1818
if (regionRegexmatchArray) {
19-
return regionRegexmatchArray[0];
19+
return regionRegexmatchArray[0].slice(1, -1);
2020
}
2121
}
2222
};

0 commit comments

Comments
 (0)