fix(clients): properly decode SQS messages

Fixes #2362.

Author: pauldraper

clients/client-sqs/package.json

@@ -58,6 +58,7 @@
     "@aws-sdk/util-utf8-browser": "3.13.1",
     "@aws-sdk/util-utf8-node": "3.13.1",
     "fast-xml-parser": "3.19.0",
+    "he": "^1.0.0",
     "tslib": "^2.0.0"
   },
   "devDependencies": {

clients/client-sqs/protocols/Aws_query.ts

@@ -102,6 +102,7 @@ import {
   SerdeContext as __SerdeContext,
 } from "@aws-sdk/types";
 import { parse as xmlParse } from "fast-xml-parser";
+import { decode as xmlDecode } from "he";
 
 export const serializeAws_queryAddPermissionCommand = async (
   input: AddPermissionCommandInput,
@@ -3130,14 +3131,6 @@ const buildHttpRpcRequest = async (
   return new __HttpRequest(contents);
 };
 
-const decodeEscapedXML = (str: string) =>
-  str
-    .replace(/&/g, "&")
-    .replace(/'/g, "'")
-    .replace(/"/g, '"')
-    .replace(/>/g, ">")
-    .replace(/&lt;/g, "<");
-
 const parseBody = (streamBody: any, context: __SerdeContext): any =>
   collectBodyString(streamBody, context).then((encoded) => {
     if (encoded.length) {
@@ -3146,7 +3139,7 @@ const parseBody = (streamBody: any, context: __SerdeContext): any =>
         ignoreAttributes: false,
         parseNodeValue: false,
         trimValues: false,
-        tagValueProcessor: (val, tagName) => (val.trim() === "" ? "" : decodeEscapedXML(val)),
+        tagValueProcessor: (val, tagName) => (val.trim() === "" ? "" : xmlDecode(val)),
       });
       const textNodeName = "#text";
       const key = Object.keys(parsedObj)[0];

yarn.lock

@@ -1697,6 +1697,11 @@
   dependencies:
     "@types/node" "*"
 
+"@types/he@^1.0.0":
+  version "1.1.1"
+  resolved "https://registry.yarnpkg.com/@types/he/-/he-1.1.1.tgz#19e14033c4ee8f1a702c74dcc6182664839ac2b7"
+  integrity sha512-jpzrsR1ns0n3kyWt92QfOUQhIuJGQ9+QGa7M62rO6toe98woQjnsnzjdMtsQXCdvjjmqjS2ZBCC7xKw0cdzU+Q==
+
 "@types/istanbul-lib-coverage@*", "@types/istanbul-lib-coverage@^2.0.0", "@types/istanbul-lib-coverage@^2.0.1":
   version "2.0.3"
   resolved "https://registry.yarnpkg.com/@types/istanbul-lib-coverage/-/istanbul-lib-coverage-2.0.3.tgz#4ba8ddb720221f432e443bd5f9117fd22cfd4762"
@@ -5803,7 +5808,7 @@ hash.js@^1.0.0, hash.js@^1.0.3:
     inherits "^2.0.3"
     minimalistic-assert "^1.0.1"
 
-[email protected]:
+[email protected], he@^1.0.0:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/he/-/he-1.2.0.tgz#84ae65fa7eafb165fddb61566ae14baf05664f0f"
   integrity sha512-F/1DnUGPopORZi0ni+CvrCgHQ5FyEAHRLSApuYWMmrbSwoN2Mn/7k+Gl38gJnR7yyDZk6WLXwiGod1JOWNDKGw==