Skip to content

Commit cee0f13

Browse files
authored
feat(s3-error-unmarshaller): add s3 customization to parse exceptions properly
1 parent bdbf9aa commit cee0f13

File tree

19 files changed

+648
-5
lines changed

19 files changed

+648
-5
lines changed

packages/client-s3-browser/S3Client.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import * as __aws_sdk_middleware_stack from "@aws-sdk/middleware-stack";
1111
import * as __aws_sdk_protocol_rest from "@aws-sdk/protocol-rest";
1212
import * as __aws_sdk_query_error_unmarshaller from "@aws-sdk/query-error-unmarshaller";
1313
import * as __aws_sdk_retry_middleware from "@aws-sdk/retry-middleware";
14+
import * as __aws_sdk_s3_error_unmarshaller from "@aws-sdk/s3-error-unmarshaller";
1415
import * as __aws_sdk_signature_v4 from "@aws-sdk/signature-v4";
1516
import * as __aws_sdk_signing_middleware from "@aws-sdk/signing-middleware";
1617
import * as __aws_sdk_stream_collector_browser from "@aws-sdk/stream-collector-browser";

packages/client-s3-browser/S3Configuration.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import * as __aws_sdk_hash_blob_browser from "@aws-sdk/hash-blob-browser";
55
import * as __aws_sdk_md5_js from "@aws-sdk/md5-js";
66
import * as __aws_sdk_middleware_serializer from "@aws-sdk/middleware-serializer";
77
import * as __aws_sdk_protocol_rest from "@aws-sdk/protocol-rest";
8-
import * as __aws_sdk_query_error_unmarshaller from "@aws-sdk/query-error-unmarshaller";
8+
import * as __aws_sdk_s3_error_unmarshaller from "@aws-sdk/s3-error-unmarshaller";
99
import * as __aws_sdk_signature_v4 from "@aws-sdk/signature-v4";
1010
import * as __aws_sdk_signing_middleware from "@aws-sdk/signing-middleware";
1111
import * as __aws_sdk_stream_collector_browser from "@aws-sdk/stream-collector-browser";
@@ -373,7 +373,7 @@ export const configurationProperties: __aws_sdk_types.ConfigurationDefinition<
373373
configuration.base64Decoder
374374
),
375375
configuration.streamCollector,
376-
__aws_sdk_query_error_unmarshaller.queryErrorUnmarshaller,
376+
__aws_sdk_s3_error_unmarshaller.s3ErrorUnmarshaller,
377377
configuration.utf8Encoder,
378378
configuration.base64Decoder
379379
)

packages/client-s3-browser/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
"@aws-sdk/protocol-rest": "^0.1.0-preview.5",
4040
"@aws-sdk/query-error-unmarshaller": "^0.1.0-preview.4",
4141
"@aws-sdk/retry-middleware": "^0.1.0-preview.3",
42+
"@aws-sdk/s3-error-unmarshaller": "^0.1.0-preview.1",
4243
"@aws-sdk/signature-v4": "^0.1.0-preview.4",
4344
"@aws-sdk/signing-middleware": "^0.1.0-preview.4",
4445
"@aws-sdk/ssec-middleware": "^0.1.0-preview.3",

packages/client-s3-node/S3Client.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import * as __aws_sdk_protocol_rest from "@aws-sdk/protocol-rest";
1313
import * as __aws_sdk_query_error_unmarshaller from "@aws-sdk/query-error-unmarshaller";
1414
import * as __aws_sdk_region_provider from "@aws-sdk/region-provider";
1515
import * as __aws_sdk_retry_middleware from "@aws-sdk/retry-middleware";
16+
import * as __aws_sdk_s3_error_unmarshaller from "@aws-sdk/s3-error-unmarshaller";
1617
import * as __aws_sdk_signature_v4 from "@aws-sdk/signature-v4";
1718
import * as __aws_sdk_signing_middleware from "@aws-sdk/signing-middleware";
1819
import * as __aws_sdk_stream_collector_node from "@aws-sdk/stream-collector-node";

packages/client-s3-node/S3Configuration.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import * as __aws_sdk_hash_stream_node from "@aws-sdk/hash-stream-node";
55
import * as __aws_sdk_middleware_serializer from "@aws-sdk/middleware-serializer";
66
import * as __aws_sdk_node_http_handler from "@aws-sdk/node-http-handler";
77
import * as __aws_sdk_protocol_rest from "@aws-sdk/protocol-rest";
8-
import * as __aws_sdk_query_error_unmarshaller from "@aws-sdk/query-error-unmarshaller";
98
import * as __aws_sdk_region_provider from "@aws-sdk/region-provider";
9+
import * as __aws_sdk_s3_error_unmarshaller from "@aws-sdk/s3-error-unmarshaller";
1010
import * as __aws_sdk_signature_v4 from "@aws-sdk/signature-v4";
1111
import * as __aws_sdk_signing_middleware from "@aws-sdk/signing-middleware";
1212
import * as __aws_sdk_stream_collector_node from "@aws-sdk/stream-collector-node";
@@ -384,7 +384,7 @@ export const configurationProperties: __aws_sdk_types.ConfigurationDefinition<
384384
configuration.base64Decoder
385385
),
386386
configuration.streamCollector,
387-
__aws_sdk_query_error_unmarshaller.queryErrorUnmarshaller,
387+
__aws_sdk_s3_error_unmarshaller.s3ErrorUnmarshaller,
388388
configuration.utf8Encoder,
389389
configuration.base64Decoder
390390
)

packages/client-s3-node/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
"@aws-sdk/query-error-unmarshaller": "^0.1.0-preview.4",
4242
"@aws-sdk/region-provider": "^0.1.0-preview.3",
4343
"@aws-sdk/retry-middleware": "^0.1.0-preview.3",
44+
"@aws-sdk/s3-error-unmarshaller": "^0.1.0-preview.1",
4445
"@aws-sdk/signature-v4": "^0.1.0-preview.4",
4546
"@aws-sdk/signing-middleware": "^0.1.0-preview.4",
4647
"@aws-sdk/ssec-middleware": "^0.1.0-preview.3",
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
/node_modules/
2+
/build/
3+
/coverage/
4+
/docs/
5+
*.tgz
6+
*.log
7+
package-lock.json
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
/src/
2+
/coverage/
3+
/docs/
4+
tsconfig.test.json
5+
6+
*.spec.js
7+
*.spec.d.ts
8+
*.spec.js.map
9+
10+
*.fixture.js
11+
*.fixture.d.ts
12+
*.fixture.js.map
Lines changed: 201 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,201 @@
1+
Apache License
2+
Version 2.0, January 2004
3+
http://www.apache.org/licenses/
4+
5+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6+
7+
1. Definitions.
8+
9+
"License" shall mean the terms and conditions for use, reproduction,
10+
and distribution as defined by Sections 1 through 9 of this document.
11+
12+
"Licensor" shall mean the copyright owner or entity authorized by
13+
the copyright owner that is granting the License.
14+
15+
"Legal Entity" shall mean the union of the acting entity and all
16+
other entities that control, are controlled by, or are under common
17+
control with that entity. For the purposes of this definition,
18+
"control" means (i) the power, direct or indirect, to cause the
19+
direction or management of such entity, whether by contract or
20+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
21+
outstanding shares, or (iii) beneficial ownership of such entity.
22+
23+
"You" (or "Your") shall mean an individual or Legal Entity
24+
exercising permissions granted by this License.
25+
26+
"Source" form shall mean the preferred form for making modifications,
27+
including but not limited to software source code, documentation
28+
source, and configuration files.
29+
30+
"Object" form shall mean any form resulting from mechanical
31+
transformation or translation of a Source form, including but
32+
not limited to compiled object code, generated documentation,
33+
and conversions to other media types.
34+
35+
"Work" shall mean the work of authorship, whether in Source or
36+
Object form, made available under the License, as indicated by a
37+
copyright notice that is included in or attached to the work
38+
(an example is provided in the Appendix below).
39+
40+
"Derivative Works" shall mean any work, whether in Source or Object
41+
form, that is based on (or derived from) the Work and for which the
42+
editorial revisions, annotations, elaborations, or other modifications
43+
represent, as a whole, an original work of authorship. For the purposes
44+
of this License, Derivative Works shall not include works that remain
45+
separable from, or merely link (or bind by name) to the interfaces of,
46+
the Work and Derivative Works thereof.
47+
48+
"Contribution" shall mean any work of authorship, including
49+
the original version of the Work and any modifications or additions
50+
to that Work or Derivative Works thereof, that is intentionally
51+
submitted to Licensor for inclusion in the Work by the copyright owner
52+
or by an individual or Legal Entity authorized to submit on behalf of
53+
the copyright owner. For the purposes of this definition, "submitted"
54+
means any form of electronic, verbal, or written communication sent
55+
to the Licensor or its representatives, including but not limited to
56+
communication on electronic mailing lists, source code control systems,
57+
and issue tracking systems that are managed by, or on behalf of, the
58+
Licensor for the purpose of discussing and improving the Work, but
59+
excluding communication that is conspicuously marked or otherwise
60+
designated in writing by the copyright owner as "Not a Contribution."
61+
62+
"Contributor" shall mean Licensor and any individual or Legal Entity
63+
on behalf of whom a Contribution has been received by Licensor and
64+
subsequently incorporated within the Work.
65+
66+
2. Grant of Copyright License. Subject to the terms and conditions of
67+
this License, each Contributor hereby grants to You a perpetual,
68+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
69+
copyright license to reproduce, prepare Derivative Works of,
70+
publicly display, publicly perform, sublicense, and distribute the
71+
Work and such Derivative Works in Source or Object form.
72+
73+
3. Grant of Patent License. Subject to the terms and conditions of
74+
this License, each Contributor hereby grants to You a perpetual,
75+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
76+
(except as stated in this section) patent license to make, have made,
77+
use, offer to sell, sell, import, and otherwise transfer the Work,
78+
where such license applies only to those patent claims licensable
79+
by such Contributor that are necessarily infringed by their
80+
Contribution(s) alone or by combination of their Contribution(s)
81+
with the Work to which such Contribution(s) was submitted. If You
82+
institute patent litigation against any entity (including a
83+
cross-claim or counterclaim in a lawsuit) alleging that the Work
84+
or a Contribution incorporated within the Work constitutes direct
85+
or contributory patent infringement, then any patent licenses
86+
granted to You under this License for that Work shall terminate
87+
as of the date such litigation is filed.
88+
89+
4. Redistribution. You may reproduce and distribute copies of the
90+
Work or Derivative Works thereof in any medium, with or without
91+
modifications, and in Source or Object form, provided that You
92+
meet the following conditions:
93+
94+
(a) You must give any other recipients of the Work or
95+
Derivative Works a copy of this License; and
96+
97+
(b) You must cause any modified files to carry prominent notices
98+
stating that You changed the files; and
99+
100+
(c) You must retain, in the Source form of any Derivative Works
101+
that You distribute, all copyright, patent, trademark, and
102+
attribution notices from the Source form of the Work,
103+
excluding those notices that do not pertain to any part of
104+
the Derivative Works; and
105+
106+
(d) If the Work includes a "NOTICE" text file as part of its
107+
distribution, then any Derivative Works that You distribute must
108+
include a readable copy of the attribution notices contained
109+
within such NOTICE file, excluding those notices that do not
110+
pertain to any part of the Derivative Works, in at least one
111+
of the following places: within a NOTICE text file distributed
112+
as part of the Derivative Works; within the Source form or
113+
documentation, if provided along with the Derivative Works; or,
114+
within a display generated by the Derivative Works, if and
115+
wherever such third-party notices normally appear. The contents
116+
of the NOTICE file are for informational purposes only and
117+
do not modify the License. You may add Your own attribution
118+
notices within Derivative Works that You distribute, alongside
119+
or as an addendum to the NOTICE text from the Work, provided
120+
that such additional attribution notices cannot be construed
121+
as modifying the License.
122+
123+
You may add Your own copyright statement to Your modifications and
124+
may provide additional or different license terms and conditions
125+
for use, reproduction, or distribution of Your modifications, or
126+
for any such Derivative Works as a whole, provided Your use,
127+
reproduction, and distribution of the Work otherwise complies with
128+
the conditions stated in this License.
129+
130+
5. Submission of Contributions. Unless You explicitly state otherwise,
131+
any Contribution intentionally submitted for inclusion in the Work
132+
by You to the Licensor shall be under the terms and conditions of
133+
this License, without any additional terms or conditions.
134+
Notwithstanding the above, nothing herein shall supersede or modify
135+
the terms of any separate license agreement you may have executed
136+
with Licensor regarding such Contributions.
137+
138+
6. Trademarks. This License does not grant permission to use the trade
139+
names, trademarks, service marks, or product names of the Licensor,
140+
except as required for reasonable and customary use in describing the
141+
origin of the Work and reproducing the content of the NOTICE file.
142+
143+
7. Disclaimer of Warranty. Unless required by applicable law or
144+
agreed to in writing, Licensor provides the Work (and each
145+
Contributor provides its Contributions) on an "AS IS" BASIS,
146+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
147+
implied, including, without limitation, any warranties or conditions
148+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
149+
PARTICULAR PURPOSE. You are solely responsible for determining the
150+
appropriateness of using or redistributing the Work and assume any
151+
risks associated with Your exercise of permissions under this License.
152+
153+
8. Limitation of Liability. In no event and under no legal theory,
154+
whether in tort (including negligence), contract, or otherwise,
155+
unless required by applicable law (such as deliberate and grossly
156+
negligent acts) or agreed to in writing, shall any Contributor be
157+
liable to You for damages, including any direct, indirect, special,
158+
incidental, or consequential damages of any character arising as a
159+
result of this License or out of the use or inability to use the
160+
Work (including but not limited to damages for loss of goodwill,
161+
work stoppage, computer failure or malfunction, or any and all
162+
other commercial damages or losses), even if such Contributor
163+
has been advised of the possibility of such damages.
164+
165+
9. Accepting Warranty or Additional Liability. While redistributing
166+
the Work or Derivative Works thereof, You may choose to offer,
167+
and charge a fee for, acceptance of support, warranty, indemnity,
168+
or other liability obligations and/or rights consistent with this
169+
License. However, in accepting such obligations, You may act only
170+
on Your own behalf and on Your sole responsibility, not on behalf
171+
of any other Contributor, and only if You agree to indemnify,
172+
defend, and hold each Contributor harmless for any liability
173+
incurred by, or claims asserted against, such Contributor by reason
174+
of your accepting any such warranty or additional liability.
175+
176+
END OF TERMS AND CONDITIONS
177+
178+
APPENDIX: How to apply the Apache License to your work.
179+
180+
To apply the Apache License to your work, attach the following
181+
boilerplate notice, with the fields enclosed by brackets "{}"
182+
replaced with your own identifying information. (Don't include
183+
the brackets!) The text should be enclosed in the appropriate
184+
comment syntax for the file format. We also recommend that a
185+
file or class name and description of purpose be included on the
186+
same "printed page" as the copyright notice for easier
187+
identification within third-party archives.
188+
189+
Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
190+
191+
Licensed under the Apache License, Version 2.0 (the "License");
192+
you may not use this file except in compliance with the License.
193+
You may obtain a copy of the License at
194+
195+
http://www.apache.org/licenses/LICENSE-2.0
196+
197+
Unless required by applicable law or agreed to in writing, software
198+
distributed under the License is distributed on an "AS IS" BASIS,
199+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
200+
See the License for the specific language governing permissions and
201+
limitations under the License.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# @aws-sdk/@aws-sdk/s3-error-unmarshaller
2+
3+
[![NPM version](https://img.shields.io/npm/v/@aws-sdk/@aws-sdk/s3-error-unmarshaller/preview.svg)](https://www.npmjs.com/package/@aws-sdk/@aws-sdk/s3-error-unmarshaller)
4+
[![NPM downloads](https://img.shields.io/npm/dm/@aws-sdk/@aws-sdk/s3-error-unmarshaller.svg)](https://www.npmjs.com/package/@aws-sdk/@aws-sdk/s3-error-unmarshaller)
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"name": "@aws-sdk/s3-error-unmarshaller",
3+
"version": "0.1.0-preview.1",
4+
"scripts": {
5+
"prepublishOnly": "tsc",
6+
"pretest": "tsc -p tsconfig.test.json",
7+
"test": "jest"
8+
},
9+
"main": "./build/index.js",
10+
"types": "./build/index.d.ts",
11+
"author": {
12+
"name": "AWS SDK for JavaScript Team",
13+
"email": "",
14+
"url": "https://aws.amazon.com/javascript/"
15+
},
16+
"license": "Apache-2.0",
17+
"dependencies": {
18+
"@aws-sdk/response-metadata-extractor": "^0.1.0-preview.4",
19+
"@aws-sdk/types": "^0.1.0-preview.3",
20+
"@aws-sdk/util-error-constructor": "^0.1.0-preview.3",
21+
"tslib": "^1.8.0"
22+
},
23+
"devDependencies": {
24+
"@types/jest": "^24.0.12",
25+
"typescript": "~3.4.0",
26+
"jest": "^24.7.1"
27+
}
28+
}
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { Member } from "@aws-sdk/types";
2+
3+
export const ERR_RESP_SHAPE: Member = {
4+
shape: {
5+
type: "structure",
6+
required: [],
7+
members: {
8+
Code: { shape: { type: "string" } },
9+
Message: { shape: { type: "string" } }
10+
}
11+
}
12+
};
13+
14+
export type ParsedErrorResponse = {
15+
Message: string;
16+
Code: string;
17+
$metadata: { requestId: string };
18+
};

0 commit comments

Comments
 (0)