Skip to content

Commit d5d061b

Browse files
authored
chore(util-endpoints): evaluate condition to true for empty string (#3933)
1 parent 1209cb1 commit d5d061b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/util-endpoints/src/utils/evaluateCondition.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ describe(evaluateCondition.name, () => {
2727

2828
describe("evaluates function", () => {
2929
describe.each([
30-
[true, "truthy", [true, 1, -1, "true", "false"]],
31-
[false, "falsy", [false, 0, -0, "", null, undefined, NaN]],
32-
])("returns %s for %s values", (result, boolStatus, testCases) => {
33-
it.each(testCases)(`${boolStatus} value: '%s'`, (mockReturn) => {
30+
[true, [true, 1, -1, "true", "false", ""]],
31+
[false, [false, 0, -0, null, undefined, NaN]],
32+
])("returns %s for", (result, testCases) => {
33+
it.each(testCases)(`value: '%s'`, (mockReturn) => {
3434
(callFunction as jest.Mock).mockReturnValue(mockReturn);
3535
const { result, toAssign } = evaluateCondition(mockFnArgs, mockOptions);
3636
expect(result).toBe(result);

packages/util-endpoints/src/utils/evaluateCondition.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export const evaluateCondition = ({ assign, ...fnArgs }: ConditionObject, option
77
}
88
const value = callFunction(fnArgs, options);
99
return {
10-
result: !!value,
10+
result: value === "" ? true : !!value,
1111
...(assign != null && { toAssign: { name: assign, value } }),
1212
};
1313
};

0 commit comments

Comments
 (0)