Skip to content

Commit ea5272e

Browse files
committed
fix: regionHostname should be from resolvedRegion
1 parent cc264ca commit ea5272e

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

packages/config-resolver/src/regionInfo/getRegionInfo.spec.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,10 @@ describe(getRegionInfo.name, () => {
8585
partition: mockPartition,
8686
});
8787

88-
expect(getResolvedHostname).toHaveBeenCalledWith(getMockResolvedRegion(regionCase), {
88+
const mockResolvedRegion = getMockResolvedRegion(regionCase);
89+
expect(getResolvedHostname).toHaveBeenCalledWith(mockResolvedRegion, {
8990
signingService: mockSigningService,
90-
regionHostname: mockGetRegionInfoOptions.regionHash[mockRegion]?.hostname,
91+
regionHostname: mockGetRegionInfoOptions.regionHash[mockResolvedRegion]?.hostname,
9192
partitionHostname: mockGetRegionInfoOptions.partitionHash[mockPartition]?.hostname,
9293
});
9394
expect(getResolvedPartition).toHaveBeenCalledWith(mockRegion, mockGetResolvedPartitionOptions);
@@ -138,9 +139,10 @@ describe(getRegionInfo.name, () => {
138139
signingRegion: mockSigningRegion,
139140
});
140141

141-
expect(getResolvedHostname).toHaveBeenCalledWith(getMockResolvedRegion(regionCase), {
142+
const mockResolvedRegion = getMockResolvedRegion(regionCase);
143+
expect(getResolvedHostname).toHaveBeenCalledWith(mockResolvedRegion, {
142144
signingService: mockSigningService,
143-
regionHostname: mockGetRegionInfoOptions.regionHash[mockRegion]?.hostname,
145+
regionHostname: mockGetRegionInfoOptions.regionHash[mockResolvedRegion]?.hostname,
144146
partitionHostname: mockGetRegionInfoOptions.partitionHash[mockPartition]?.hostname,
145147
});
146148
expect(getResolvedPartition).toHaveBeenCalledWith(mockRegion, mockGetResolvedPartitionOptions);
@@ -190,9 +192,10 @@ describe(getRegionInfo.name, () => {
190192
partition: mockPartition,
191193
});
192194

193-
expect(getResolvedHostname).toHaveBeenCalledWith(getMockResolvedRegion(regionCase), {
195+
const mockResolvedRegion = getMockResolvedRegion(regionCase);
196+
expect(getResolvedHostname).toHaveBeenCalledWith(mockResolvedRegion, {
194197
signingService: mockSigningService,
195-
regionHostname: mockGetRegionInfoOptions.regionHash[mockRegion]?.hostname,
198+
regionHostname: mockGetRegionInfoOptions.regionHash[mockResolvedRegion]?.hostname,
196199
partitionHostname: mockGetRegionInfoOptions.partitionHash[mockPartition]?.hostname,
197200
});
198201
expect(getResolvedPartition).toHaveBeenCalledWith(mockRegion, mockGetResolvedPartitionOptions);

packages/config-resolver/src/regionInfo/getRegionInfo.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const getRegionInfo = (
2222
signingService,
2323
hostname: getResolvedHostname(resolvedRegion, {
2424
signingService,
25-
regionHostname: regionHash[region]?.hostname,
25+
regionHostname: regionHash[resolvedRegion]?.hostname,
2626
partitionHostname: partitionHash[partition]?.hostname,
2727
}),
2828
...(regionHash[resolvedRegion]?.signingRegion && {

0 commit comments

Comments
 (0)