chore: fix more bugs with using let/const

Author: trivikr

features/dynamodb/step_definitions/dynamodb.js

@@ -92,7 +92,7 @@ function createTable(world, callback) {
 Given(/^I have a table$/, function(callback) {
   const world = this;
   this.service.listTables({}, function(err, data) {
-    for (const i = 0; i < data.TableNames.length; i++) {
+    for (let i = 0; i < data.TableNames.length; i++) {
       if (data.TableNames[i] == world.tableName) {
         callback();
         return;
@@ -106,7 +106,7 @@ When(/^I create a table$/, function(callback) {
   const world = this;
   this.tableName = this.uniqueName("aws-sdk-js-integration");
   this.service.listTables({}, function(err, data) {
-    for (const i = 0; i < data.TableNames.length; i++) {
+    for (let i = 0; i < data.TableNames.length; i++) {
       if (data.TableNames[i] == world.tableName) {
         callback();
         return;

features/extra/assertions.js

@@ -9,12 +9,12 @@ assert.match = function assertMatches(string, matcher, message) {
 
 assert.contains = function assertContains(list, matcher, message) {
   let found = false;
-  for (const i in list) {
-    if (!list.hasOwnProperty(i)) continue;
+  for (const itemIndex in list) {
+    if (!list.hasOwnProperty(itemIndex)) continue;
     if (typeof matcher === "function") {
-      found = matcher(list[i]);
+      found = matcher(list[itemIndex]);
     } else {
-      found = list[i] === matcher;
+      found = list[itemIndex] === matcher;
     }
     if (found) return;
   }

features/sqs/step_definitions/queues.js

@@ -18,9 +18,9 @@ Then(/^list queues should eventually return the queue urls$/, function(
     callback,
     function(next) {
       next.condition = function() {
-        const matchingCount = 0;
-        for (const i = 0; i < this.createdQueues.length; ++i) {
-          for (const j = 0; j < this.data.QueueUrls.length; ++j) {
+        let matchingCount = 0;
+        for (let i = 0; i < this.createdQueues.length; ++i) {
+          for (let j = 0; j < this.data.QueueUrls.length; ++j) {
             if (this.createdQueues[i] == this.data.QueueUrls[j]) {
               matchingCount++;
             }