fix: improve error messages

Chase Coalwell · Chase Coalwell · commit f6de5850f373 · 2020-01-20T10:33:26.000-08:00
diff --git a/packages/middleware-sdk-sqs/src/receive-message.ts b/packages/middleware-sdk-sqs/src/receive-message.ts
@@ -41,7 +41,9 @@ export function receiveMessageMiddleware(
       }
     }
     if (messageIds.length > 0) {
-      throw new Error("Invalid messages: " + messageIds.join(", "));
+      throw new Error(
+        "Invalid MD5 checksum on messages: " + messageIds.join(", ")
+      );
     }
 
     return next({
diff --git a/packages/middleware-sdk-sqs/src/receive-messages.spec.ts b/packages/middleware-sdk-sqs/src/receive-messages.spec.ts
@@ -50,7 +50,9 @@ describe("receiveMessageMiddleware", () => {
         input: {}
       });
     } catch (e) {
-      expect(e).toEqual(new Error("Invalid messages: barMessage"));
+      expect(e).toEqual(
+        new Error("Invalid MD5 checksum on messages: barMessage")
+      );
     }
     expect(mockHashUpdate.mock.calls.length).toBe(2);
     expect(mockHashDigest.mock.calls.length).toBe(2);
diff --git a/packages/middleware-sdk-sqs/src/send-message-batch.spec.ts b/packages/middleware-sdk-sqs/src/send-message-batch.spec.ts
@@ -62,7 +62,9 @@ describe("sendMessageBatchMiddleware", () => {
         }
       });
     } catch (e) {
-      expect(e).toEqual(new Error("Invalid messages: barMessage"));
+      expect(e).toEqual(
+        new Error("Invalid MD5 checksum on messages: barMessage")
+      );
     }
     expect(mockHashUpdate.mock.calls.length).toBe(2);
     expect(mockHashDigest.mock.calls.length).toBe(2);
diff --git a/packages/middleware-sdk-sqs/src/send-message-batch.ts b/packages/middleware-sdk-sqs/src/send-message-batch.ts
@@ -49,7 +49,9 @@ export function sendMessageBatchMiddleware(
       }
     }
     if (messageIds.length > 0) {
-      throw new Error("Invalid messages: " + messageIds.join(", "));
+      throw new Error(
+        "Invalid MD5 checksum on messages: " + messageIds.join(", ")
+      );
     }
 
     return next({

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,9 @@ export function receiveMessageMiddleware(`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`	`if (messageIds.length > 0) {`
`44`		`- throw new Error("Invalid messages: " + messageIds.join(", "));`
	`44`	`+ throw new Error(`
	`45`	`+ "Invalid MD5 checksum on messages: " + messageIds.join(", ")`
	`46`	`+ );`
`45`	`47`	`}`
`46`	`48`
`47`	`49`	`return next({`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,9 @@ describe("sendMessageBatchMiddleware", () => {`
`62`	`62`	`}`
`63`	`63`	`});`
`64`	`64`	`} catch (e) {`
`65`		`- expect(e).toEqual(new Error("Invalid messages: barMessage"));`
	`65`	`+ expect(e).toEqual(`
	`66`	`+ new Error("Invalid MD5 checksum on messages: barMessage")`
	`67`	`+ );`
`66`	`68`	`}`
`67`	`69`	`expect(mockHashUpdate.mock.calls.length).toBe(2);`
`68`	`70`	`expect(mockHashDigest.mock.calls.length).toBe(2);`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,9 @@ export function sendMessageBatchMiddleware(`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`	`if (messageIds.length > 0) {`
`52`		`- throw new Error("Invalid messages: " + messageIds.join(", "));`
	`52`	`+ throw new Error(`
	`53`	`+ "Invalid MD5 checksum on messages: " + messageIds.join(", ")`
	`54`	`+ );`
`53`	`55`	`}`
`54`	`56`
`55`	`57`	`return next({`