Fix config signingName and Content-Type header for rest-json protocol #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4k9c0
reviewed
Jan 29, 2019
| * If payload is supplied in input, the content-type should be set according to payload shape; | ||
| * If payload is specified but not supplied in input, no content-type header is needed; | ||
| * If there's no payload in input shape, set content-type as 'application/json'; | ||
| * @param operation |
| } = operation; | ||
| if (protocol !== 'rest-json') return contentTypeHeader | ||
| if (typeof (inputShape.shape as Structure).payload === 'string') { | ||
| const payloadMemberName = (inputShape.shape as Structure).payload!; |
There was a problem hiding this comment.
What is the ! doing at the end of this line?
There was a problem hiding this comment.
The payload can be string or undefined. But in fact the payload here cannot be undefined because of the if statement. The ! is to persuade Typescript that payload always exists
AllanZhengYP
force-pushed
the
fix-config-signingname
branch
from
bbbfff6 to
2183c10
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issues in code generator pinpoint client is usable now.
@c4k9c0
The first commit is the code change to code generator CLI;
The last commit is just generated code as example;