Skip to content

chore(api-gateway): generate client with httpQueryParams #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 13, 2021

Issue

Draft PR (not to be merged) for testing #2246

Description

chore(api-gateway): generate client with httpQueryParams

Testing

Verified the operation getSdk which uses httpQueryParams trait for parameters key returns same output from workspace client:

const { APIGateway } = require("@aws-sdk/client-api-gateway");
// const { APIGateway } = require("../aws-sdk-js-v3/clients/client-api-gateway");

(async () => {
  const region = "us-west-2";
  const client = new APIGateway({ region });

  const restApiId = "restApiId"; // Populate rest API ID
  const stageName = "latest"; // Populate Stage Name
  const sdkType = "ruby";
  const parameters = { "service.name": "name" }; // Populate Service Name

  console.log(
    await client.getSdk({ restApiId, stageName, sdkType, parameters })
  );
})();

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Apr 13, 2021

Closing as this PR was just created for testing

@trivikr
Copy link
Member Author

trivikr commented Apr 14, 2021

Reopening to test simplification of request query strings for httpQueryParams smithy-lang/smithy-typescript#311 (comment)

@trivikr trivikr reopened this Apr 14, 2021
@trivikr
Copy link
Member Author

trivikr commented Apr 14, 2021

Closing as tests are successful.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 60ef7d6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
@trivikr trivikr deleted the api-gateway-httpQueryParams-test branch June 1, 2021 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants