Skip to content

Add a base credential provider package #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2017
Merged

Add a base credential provider package #23

merged 2 commits into from
Jun 15, 2017

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jun 13, 2017

Spun off from #5

This PR adds the base functionality necessary for a functional credential provider. It includes a way to chain providers together into a single provider, decorate a provider function with memoization, and convert a static credentials object into a provider function.

@jeskew jeskew requested review from awood45 and chrisradek June 13, 2017 19:49
@jeskew jeskew mentioned this pull request Jun 13, 2017
5 tasks
import {fromCredentials} from "../lib/fromCredentials";

describe('fromCredentials', () => {
it('should convert credentials into a credential provider', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Should a test also be included for sessionToken/expiration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

/**
* An error representing a failure of an individual credential provider.
*
* This error class has special meaning to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment trails off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops... I'll finish the thought.

Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeskew jeskew merged commit cebedea into aws:master Jun 15, 2017
@jeskew jeskew deleted the feature/credential-provider-base branch June 15, 2017 17:22
trivikr referenced this pull request in trivikr/aws-sdk-js-v3 Dec 10, 2018
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants