-
Notifications
You must be signed in to change notification settings - Fork 619
Add a base credential provider package #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
import {fromCredentials} from "../lib/fromCredentials"; | ||
|
||
describe('fromCredentials', () => { | ||
it('should convert credentials into a credential provider', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Should a test also be included for sessionToken/expiration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
/** | ||
* An error representing a failure of an individual credential provider. | ||
* | ||
* This error class has special meaning to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment trails off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops... I'll finish the thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a base credential provider package
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Spun off from #5
This PR adds the base functionality necessary for a functional credential provider. It includes a way to chain providers together into a single provider, decorate a provider function with memoization, and convert a static credentials object into a provider function.