chore(clients): regenerate clients with DirectedCodegen #3963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on smithy-typescript changes in smithy-lang/smithy-typescript#585
trivikr
approved these changes
Sep 16, 2022
|
I'm also not sure why the rearrangement is happening. This PR looks good to me. If the situation affects more clients, we'll prioritize sorting the models. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on running
yarn generate-clientson top of using smithy-typescript changes in smithy-lang/smithy-typescript#585.On 8/31 there were no diffs. On 9/15 when I rebase and regenerate, I do not expect any diff, but I'm seeing this diff, just in 1 client - identitystore. It is just moving couple of exceptions to a different location. I don't know why there is this diff and just for this one client - not sure what is special about it. Between 8/31-9/15 the only changes in smithy-typescript are rebasing and adding the EndpointV2 logic to DirectedTypeScriptCodegen (what used to be in CodegenVistor, which is deleted in favor of DirectedTypeScriptCodegen).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.