-
Notifications
You must be signed in to change notification settings - Fork 619
feat: enable clockSkew correction by default #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #459 +/- ##
==================================================
+ Coverage 95.13% 95.17% +0.03%
==================================================
Files 72 72
Lines 1378 1389 +11
Branches 269 272 +3
==================================================
+ Hits 1311 1322 +11
Misses 67 67
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just have one minor comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
N/A
Description of changes:
Enables clockSkew correction by default
In v2:
applyClockOffset
is called in nameHTTP_HEADERS
with eventNamehttpHeaders
(code)How signing works in v3:
In v3 smithy-codegen branch:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.